cc: Fix data race in cc::TaskState::IsFinished.

cc: Fix data race in cc::TaskState::IsFinished.

The https://codereview.chromium.org/1866043006/ caused data race, as
the worker and origin threads try to access the Task::state() at the
same time. The member to be accessed on origin thread is now kept
different as it was previously. Now Task::state() is used in worker
thread. It also used in origin thread, when it is safe to be used.
e.g. Task has been processed completely by task graph runner.

BUG=615809, 615340
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/535763c29025109f45c9230ca57e35e535a1175a
Cr-Commit-Position: refs/heads/master@{#396741}

[prashant.n, 2016-05-30 13:48:14]

Description was changed from

==========
cc: Fix data race in cc::TaskState::IsFinished.

The worker and origin threads try to access the Task::state() at the
same time causing race condition. The member to be accessed on origin
thread is now kept different as it was previously. Now Task::state() is
used in worker thread only or in tests.

BUG=615809, 615340
==========

to

==========
cc: Fix data race in cc::TaskState::IsFinished.

The worker and origin threads try to access the Task::state() at the
same time causing race condition. The member to be accessed on origin
thread is now kept different as it was previously. Now Task::state() is
used in worker thread only or in tests.

BUG=615809, 615340
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[prashant.n, 2016-05-30 13:51:23]

Description was changed from

==========
cc: Fix data race in cc::TaskState::IsFinished.

The worker and origin threads try to access the Task::state() at the
same time causing race condition. The member to be accessed on origin
thread is now kept different as it was previously. Now Task::state() is
used in worker thread only or in tests.

BUG=615809, 615340
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Fix data race in cc::TaskState::IsFinished.

The https://codereview.chromium.org/1866043006/ caused data race, as
the worker and origin threads try to access the Task::state() at the
same time. The member to be accessed on origin thread is now kept
different as it was previously. Now Task::state() is used in worker
thread only or in tests.

BUG=615809, 615340
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[prashant.n, 2016-05-30 13:51:23]

prashant.n@samsung.com changed reviewers:
+ reveman@chromium.org

[prashant.n, 2016-05-30 13:57:09]

Description was changed from

==========
cc: Fix data race in cc::TaskState::IsFinished.

The https://codereview.chromium.org/1866043006/ caused data race, as
the worker and origin threads try to access the Task::state() at the
same time. The member to be accessed on origin thread is now kept
different as it was previously. Now Task::state() is used in worker
thread only or in tests.

BUG=615809, 615340
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Fix data race in cc::TaskState::IsFinished.

The https://codereview.chromium.org/1866043006/ caused data race, as
the worker and origin threads try to access the Task::state() at the
same time. The member to be accessed on origin thread is now kept
different as it was previously. Now Task::state() is used in worker
thread. It also used in origin thread, when it is safe to be used.
e.g. Task has been processed completely by task graph runner.

BUG=615809, 615340
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[reveman, 2016-05-30 14:04:47]

https://codereview.chromium.org/2018353005/diff/1/cc/raster/tile_task.h
File cc/raster/tile_task.h (right):

https://codereview.chromium.org/2018353005/diff/1/cc/raster/tile_task.h#newco...
cc/raster/tile_task.h:32: bool HasEnded() const;
As we set this right after OnTaskCompleted(), would it make sense to instead
name it DidComplete/HasCompleted/did_complete_?

[reveman, 2016-05-30 14:44:19]

lgtm

[prashant.n, 2016-05-30 15:40:16]

The CQ bit was checked by prashant.n@samsung.com

[commit-bot: I haz the power, 2016-05-30 15:40:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2018353005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2018353005/20001

[commit-bot: I haz the power, 2016-05-30 17:39:14]

Description was changed from

==========
cc: Fix data race in cc::TaskState::IsFinished.

The https://codereview.chromium.org/1866043006/ caused data race, as
the worker and origin threads try to access the Task::state() at the
same time. The member to be accessed on origin thread is now kept
different as it was previously. Now Task::state() is used in worker
thread. It also used in origin thread, when it is safe to be used.
e.g. Task has been processed completely by task graph runner.

BUG=615809, 615340
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Fix data race in cc::TaskState::IsFinished.

The https://codereview.chromium.org/1866043006/ caused data race, as
the worker and origin threads try to access the Task::state() at the
same time. The member to be accessed on origin thread is now kept
different as it was previously. Now Task::state() is used in worker
thread. It also used in origin thread, when it is safe to be used.
e.g. Task has been processed completely by task graph runner.

BUG=615809, 615340
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-05-30 17:39:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-30 17:40:39]

Description was changed from

==========
cc: Fix data race in cc::TaskState::IsFinished.

The https://codereview.chromium.org/1866043006/ caused data race, as
the worker and origin threads try to access the Task::state() at the
same time. The member to be accessed on origin thread is now kept
different as it was previously. Now Task::state() is used in worker
thread. It also used in origin thread, when it is safe to be used.
e.g. Task has been processed completely by task graph runner.

BUG=615809, 615340
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Fix data race in cc::TaskState::IsFinished.

The https://codereview.chromium.org/1866043006/ caused data race, as
the worker and origin threads try to access the Task::state() at the
same time. The member to be accessed on origin thread is now kept
different as it was previously. Now Task::state() is used in worker
thread. It also used in origin thread, when it is safe to be used.
e.g. Task has been processed completely by task graph runner.

BUG=615809, 615340
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/535763c29025109f45c9230ca57e35e535a1175a
Cr-Commit-Position: refs/heads/master@{#396741}
==========

[commit-bot: I haz the power, 2016-05-30 17:40:40]

Patchset 2 (id:??) landed as
https://crrev.com/535763c29025109f45c9230ca57e35e535a1175a
Cr-Commit-Position: refs/heads/master@{#396741}