Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1089)

Issue 1885873002: cc: Rename TileTaskClient interface to RasterBufferProvider. (Closed)

Created:
4 years, 8 months ago by prashant.n
Modified:
4 years, 8 months ago
Reviewers:
reveman, vmpstr, ericrk
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_schedule
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Rename TileTaskClient interface to RasterBufferProvider. Rename TileTaskClient interface to RasterBufferProvider to depict what it does. This patch moves the interface to raster_buffer.h. BUG=599863 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/0bab14526b98f6ef643a5025576c699280028cb5 Cr-Commit-Position: refs/heads/master@{#387866}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Patch Set 4 : Removed patch dependency. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -65 lines) Patch
M cc/raster/bitmap_tile_task_worker_pool.h View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M cc/raster/bitmap_tile_task_worker_pool.cc View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M cc/raster/gpu_tile_task_worker_pool.h View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M cc/raster/gpu_tile_task_worker_pool.cc View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M cc/raster/one_copy_tile_task_worker_pool.h View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M cc/raster/one_copy_tile_task_worker_pool.cc View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M cc/raster/raster_buffer.h View 1 chunk +14 lines, -0 lines 0 comments Download
M cc/raster/tile_task_runner.h View 1 2 3 2 chunks +6 lines, -18 lines 0 comments Download
M cc/raster/tile_task_worker_pool.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M cc/raster/tile_task_worker_pool.cc View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M cc/raster/tile_task_worker_pool_perftest.cc View 1 2 3 3 chunks +8 lines, -7 lines 0 comments Download
M cc/raster/tile_task_worker_pool_unittest.cc View 1 2 3 2 chunks +4 lines, -5 lines 0 comments Download
M cc/raster/zero_copy_tile_task_worker_pool.h View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M cc/raster/zero_copy_tile_task_worker_pool.cc View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M cc/test/fake_tile_manager.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M cc/tiles/gpu_image_decode_controller.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M cc/tiles/software_image_decode_controller.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M cc/tiles/tile_manager.cc View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M cc/tiles/tile_manager_perftest.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M cc/tiles/tile_manager_unittest.cc View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
prashant.n
ptal.
4 years, 8 months ago (2016-04-13 10:54:06 UTC) #3
prashant.n
ptal - patch #2.
4 years, 8 months ago (2016-04-15 07:04:01 UTC) #4
ericrk
Good simplification. Thanks. LGTM
4 years, 8 months ago (2016-04-15 21:16:39 UTC) #5
reveman
lgtm
4 years, 8 months ago (2016-04-17 20:27:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1885873002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1885873002/60001
4 years, 8 months ago (2016-04-18 06:34:41 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-18 07:33:01 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 07:34:40 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0bab14526b98f6ef643a5025576c699280028cb5
Cr-Commit-Position: refs/heads/master@{#387866}

Powered by Google App Engine
This is Rietveld 408576698