content: Rename num raster threads -> num worker threads.

content: Rename num raster threads -> num worker threads.

This patch renames all variables related to raster threads to worker
threads.

BUG=599863

[prashant.n, 2016-06-01 02:39:28]

prashant.n@samsung.com changed reviewers:
+ avi@chromium.org, reveman@chromium.org, sky@chromium.org

[prashant.n, 2016-06-01 02:39:29]

ptal. avi@ for src/content and sky@ for src/chrome

[reveman, 2016-06-01 02:43:21]

non-owner lgtm

[Avi (use Gerrit), 2016-06-01 03:02:41]

LGTM

Hoping the grand thread unification helps clear all this out.

[prashant.n, 2016-06-01 08:34:31]

The CQ bit was checked by prashant.n@samsung.com

[prashant.n, 2016-06-01 08:34:31]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2020243004/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-06-01 08:34:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2020243004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2020243004/20001

[prashant.n, 2016-06-01 08:38:21]

The CQ bit was unchecked by prashant.n@samsung.com

[prashant.n, 2016-06-01 08:42:17]

prashant.n@samsung.com changed reviewers:
+ piman@chromium.org

[prashant.n, 2016-06-01 08:42:17]

+piman@ for chrome/browser/chromeos/login

[prashant.n, 2016-06-01 10:53:15]

Description was changed from

==========
content: Rename num raster threads -> num worker threads.

This patch renames all variables related to raster threads to worker
threads.

BUG=599863
==========

to

==========
content: Rename num raster threads -> num worker threads.

This patch renames all variables related to raster threads to worker
threads.

BUG=599863
==========

[prashant.n, 2016-06-01 10:53:15]

prashant.n@samsung.com changed reviewers:
+ rkaplow@chromium.org

[prashant.n, 2016-06-01 10:53:49]

+rkaplow@ for tools/metrics/histograms/histograms.xml

[rkaplow, 2016-06-01 14:14:57]

lgtm

[sky, 2016-06-01 15:33:49]

https://codereview.chromium.org/2020243004/diff/40001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2020243004/diff/40001/chrome/app/generated_re...
chrome/app/generated_resources.grd:3749: +          • <ph
name="PERMISSION">$1<ex>Read and change all your data on the websites you
visit</ex></ph>
What changed on this line?

https://codereview.chromium.org/2020243004/diff/40001/chrome/app/generated_re...
chrome/app/generated_resources.grd:6320: +      <message
name="IDS_FLAGS_NUM_WORKER_THREADS_NAME" desc="Name of about:flags option for
number of worker threads.">
Number of worker threads implies to me it is the number of worker threads used
throughout chrome. Isn't this number of worker threads for compositing?

[prashant.n, 2016-06-01 15:42:28]

https://codereview.chromium.org/2020243004/diff/40001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2020243004/diff/40001/chrome/app/generated_re...
chrome/app/generated_resources.grd:3749: +          • <ph
name="PERMISSION">$1<ex>Read and change all your data on the websites you
visit</ex></ph>
I didnot modify this. I'll check why this has come.

https://codereview.chromium.org/2020243004/diff/40001/chrome/app/generated_re...
chrome/app/generated_resources.grd:6320: +      <message
name="IDS_FLAGS_NUM_WORKER_THREADS_NAME" desc="Name of about:flags option for
number of worker threads.">
On 2016/06/01 15:33:49, sky wrote:
> Number of worker threads implies to me it is the number of worker threads used
> throughout chrome. Isn't this number of worker threads for compositing?

Basically these threads are used for compositing -> (raster, image decode) +
non-compositing -> media video decoding. In a way it is multipurpose, but not
fully generic that other than above nobody uses it.

[sky, 2016-06-01 15:49:55]

On Wed, Jun 1, 2016 at 8:42 AM,  <prashant.n@samsung.com> wrote:
>
>
https://codereview.chromium.org/2020243004/diff/40001/chrome/app/generated_re...
> File chrome/app/generated_resources.grd (right):
>
>
https://codereview.chromium.org/2020243004/diff/40001/chrome/app/generated_re...
> chrome/app/generated_resources.grd:3749: + • <ph
> name="PERMISSION">$1<ex>Read and change all your data on the websites
> you visit</ex></ph>
> I didnot modify this. I'll check why this has come.
>
>
https://codereview.chromium.org/2020243004/diff/40001/chrome/app/generated_re...
> chrome/app/generated_resources.grd:6320: + <message
> name="IDS_FLAGS_NUM_WORKER_THREADS_NAME" desc="Name of about:flags
> option for number of worker threads.">
> On 2016/06/01 15:33:49, sky wrote:
>> Number of worker threads implies to me it is the number of worker
> threads used
>> throughout chrome. Isn't this number of worker threads for
> compositing?
>
> Basically these threads are used for compositing -> (raster, image
> decode) + non-compositing -> media video decoding. In a way it is
> multipurpose, but not fully generic that other than above nobody uses
> it.

But it is not worker threads across all of chrome, right?
>
> https://codereview.chromium.org/2020243004/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[prashant.n, 2016-06-01 15:53:32]

> But it is not worker threads across all of chrome, right?

Not.

reveman@, do we have any plans to make this fully multipurpose to be used across
chrome?

[prashant.n, 2016-06-01 17:05:16]

I guess as per current codebase, "kNumCompositorWorkerThreads" would suite more
then as results of these tasks are finally used in compositing.

[prashant.n, 2016-06-02 14:33:36]

sky@, ptal.

Now I've changed to reflect Categorized Worker Threads as we create
CategorizedWorkerPoolThreads.

https://codereview.chromium.org/2020243004/diff/70001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2020243004/diff/70001/chrome/app/generated_re...
chrome/app/generated_resources.grd:3749: +          • <ph
name="PERMISSION">$1<ex>Read and change all your data on the websites you
visit</ex></ph>
This lines gets automatically added. I guess may be EOL correction.

[prashant.n, 2016-06-02 14:35:51]

The CQ bit was checked by prashant.n@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-02 14:36:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2020243004/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2020243004/70001

[commit-bot: I haz the power, 2016-06-02 14:49:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 14:49:41]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[reveman, 2016-06-02 15:18:06]

On 2016/06/01 at 15:53:32, prashant.n wrote:
> > But it is not worker threads across all of chrome, right?
> 
> Not.
> 
> reveman@, do we have any plans to make this fully multipurpose to be used
across chrome?

They are not used by anything but cc/ and media/ today but they are
multi-purpose and could be used across all of Chrome. Using them across all of
Chrome could be a good way to reduce the worker threads we create for each
renderer process and it would also let other code take advantage of big.LITTLE
improvements that this worker pool has been carefully adjusted for.

[prashant.n, 2016-06-02 15:33:50]

On 2016/06/02 15:18:06, reveman wrote:
> On 2016/06/01 at 15:53:32, prashant.n wrote:
> > > But it is not worker threads across all of chrome, right?
> > 
> > Not.
> > 
> > reveman@, do we have any plans to make this fully multipurpose to be used
> across chrome?
> 
> They are not used by anything but cc/ and media/ today but they are
> multi-purpose and could be used across all of Chrome. Using them across all of
> Chrome could be a good way to reduce the worker threads we create for each
> renderer process and it would also let other code take advantage of big.LITTLE
> improvements that this worker pool has been carefully adjusted for.

Ahhh! Then would patch set 3 work then?

[reveman, 2016-06-02 15:38:38]

On 2016/06/02 at 15:33:50, prashant.n wrote:
> On 2016/06/02 15:18:06, reveman wrote:
> > On 2016/06/01 at 15:53:32, prashant.n wrote:
> > > > But it is not worker threads across all of chrome, right?
> > > 
> > > Not.
> > > 
> > > reveman@, do we have any plans to make this fully multipurpose to be used
> > across chrome?
> > 
> > They are not used by anything but cc/ and media/ today but they are
> > multi-purpose and could be used across all of Chrome. Using them across all
of
> > Chrome could be a good way to reduce the worker threads we create for each
> > renderer process and it would also let other code take advantage of
big.LITTLE
> > improvements that this worker pool has been carefully adjusted for.
> 
> Ahhh! Then would patch set 3 work then?

Not sure we should name it based on what it can be used for or what it's
currently used for in Chrome. Whatever sky@ prefers. Either way is fine with me.

[prashant.n, 2016-06-07 04:32:22]

sky@, can you pls. comment on this?

[sky, 2016-06-07 15:43:45]

https://codereview.chromium.org/2020243004/diff/90001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2020243004/diff/90001/chrome/app/generated_re...
chrome/app/generated_resources.grd:3749: +          • <ph
name="PERMISSION">$1<ex>Read and change all your data on the websites you
visit</ex></ph>
I asked about this last time around and you have yet to fix it. Please revert
changes to this line.

https://codereview.chromium.org/2020243004/diff/90001/content/public/common/c...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/2020243004/diff/90001/content/public/common/c...
content/public/common/content_switches.cc:668: const char
kNumCategorizedWorkerThreads[] = "num-categorized-worker-threads";
I am not familiar with this code, but given the comment above it says 'rasterize
content', why is the variable named categorized?

[prashant.n, 2016-06-07 15:57:16]

https://codereview.chromium.org/2020243004/diff/90001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2020243004/diff/90001/chrome/app/generated_re...
chrome/app/generated_resources.grd:3749: +          • <ph
name="PERMISSION">$1<ex>Read and change all your data on the websites you
visit</ex></ph>
On 2016/06/07 15:43:45, sky wrote:
> I asked about this last time around and you have yet to fix it. Please revert
> changes to this line.

Yes. But this gets added automatically even I don't change it.

https://codereview.chromium.org/2020243004/diff/90001/content/public/common/c...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/2020243004/diff/90001/content/public/common/c...
content/public/common/content_switches.cc:668: const char
kNumCategorizedWorkerThreads[] = "num-categorized-worker-threads";
On 2016/06/07 15:43:45, sky wrote:
> I am not familiar with this code, but given the comment above it says
'rasterize
> content', why is the variable named categorized?

I'll change the comment. Basically these threads are used multipurpose and
mainly to run the categorized tasks.

https://cs.chromium.org/chromium/src/content/renderer/categorized_worker_pool...