Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2021023002: cc: Rename CompleteOnOriginThread() -> OnTaskCompleted() in tests. (Closed)

Created:
4 years, 6 months ago by prashant.n
Modified:
4 years, 6 months ago
Reviewers:
reveman, ericrk
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_notify_schedule_1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Rename CompleteOnOriginThread() -> OnTaskCompleted() in tests. Rename to OnTaskCompleted() in task_graph_runner_test_template.h. BUG=599863 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/f5564e64f63b01ae35fa70e9e0a9f71f30d859f1 Cr-Commit-Position: refs/heads/master@{#397305}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M cc/test/task_graph_runner_test_template.h View 2 chunks +2 lines, -4 lines 0 comments Download
M cc/test/task_graph_runner_test_template.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (8 generated)
prashant.n
ptal.
4 years, 6 months ago (2016-05-30 10:46:56 UTC) #3
prashant.n
+reveman@, as he was also involved in reviewing the parent CL for this.
4 years, 6 months ago (2016-06-01 12:20:32 UTC) #5
reveman
lgtm
4 years, 6 months ago (2016-06-01 14:16:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021023002/20001
4 years, 6 months ago (2016-06-02 04:10:49 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/237589)
4 years, 6 months ago (2016-06-02 04:22:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021023002/20001
4 years, 6 months ago (2016-06-02 05:18:21 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-02 05:58:10 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 06:00:27 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f5564e64f63b01ae35fa70e9e0a9f71f30d859f1
Cr-Commit-Position: refs/heads/master@{#397305}

Powered by Google App Engine
This is Rietveld 408576698