Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issue 2021323002: content: Rename RasterWorkerPool -> CategorizedWorkerPool. (Closed)

Created:
4 years, 6 months ago by prashant.n
Modified:
4 years, 6 months ago
CC:
blink-worker-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, kinuko+watch, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@task_graph_runner_test_2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Rename RasterWorkerPool -> CategorizedWorkerPool. When this class was implemented, it was used for only raster work. But we had started using it for other tasks, along with raster tasks, being scheduled with different interfaces provided in the class. BUG=599863 Committed: https://crrev.com/fad657e7142a08ebe2f632ae70149f5719c26a58 Cr-Commit-Position: refs/heads/master@{#397079}

Patch Set 1 #

Total comments: 2

Patch Set 2 : feedback #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -771 lines) Patch
M base/threading/thread_restrictions.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_renderer.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
A + content/renderer/categorized_worker_pool.h View 1 4 chunks +17 lines, -17 lines 0 comments Download
A + content/renderer/categorized_worker_pool.cc View 19 chunks +48 lines, -44 lines 0 comments Download
A content/renderer/categorized_worker_pool_unittest.cc View 1 chunk +122 lines, -0 lines 0 comments Download
D content/renderer/raster_worker_pool.h View 1 chunk +0 lines, -148 lines 0 comments Download
D content/renderer/raster_worker_pool.cc View 1 chunk +0 lines, -427 lines 0 comments Download
D content/renderer/raster_worker_pool_unittest.cc View 1 chunk +0 lines, -120 lines 0 comments Download
M content/renderer/render_thread_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 8 chunks +10 lines, -8 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 25 (13 generated)
prashant.n
ptal. I'll submit the kNumRasterThreads change in another CL.
4 years, 6 months ago (2016-05-31 15:24:10 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021323002/1
4 years, 6 months ago (2016-05-31 15:46:47 UTC) #5
reveman
lgtm, just a small request. +avi https://codereview.chromium.org/2021323002/diff/1/content/renderer/categorized_worker_pool.h File content/renderer/categorized_worker_pool.h (right): https://codereview.chromium.org/2021323002/diff/1/content/renderer/categorized_worker_pool.h#newcode30 content/renderer/categorized_worker_pool.h:30: // 3. It's ...
4 years, 6 months ago (2016-05-31 16:05:47 UTC) #7
Avi (use Gerrit)
It's as good a name as any. LGTM
4 years, 6 months ago (2016-05-31 16:10:43 UTC) #8
prashant.n
https://codereview.chromium.org/2021323002/diff/1/content/renderer/categorized_worker_pool.h File content/renderer/categorized_worker_pool.h (right): https://codereview.chromium.org/2021323002/diff/1/content/renderer/categorized_worker_pool.h#newcode30 content/renderer/categorized_worker_pool.h:30: // 3. It's also possible to get the underlying ...
4 years, 6 months ago (2016-05-31 16:46:08 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/237872)
4 years, 6 months ago (2016-05-31 16:47:48 UTC) #11
prashant.n
+danakj | jam
4 years, 6 months ago (2016-05-31 16:56:09 UTC) #13
commit-bot: I haz the power
This CL has an open dependency (Issue 2021023002 Patch 1). Please resolve the dependency and ...
4 years, 6 months ago (2016-05-31 16:57:06 UTC) #17
danakj
base LGTM
4 years, 6 months ago (2016-05-31 18:28:19 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2021323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2021323002/40001
4 years, 6 months ago (2016-06-01 05:29:32 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-01 07:52:31 UTC) #23
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 07:54:02 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fad657e7142a08ebe2f632ae70149f5719c26a58
Cr-Commit-Position: refs/heads/master@{#397079}

Powered by Google App Engine
This is Rietveld 408576698