Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1861623003: cc: Refactor OneCopyTileTaskWorkerPool. (Closed)

Created:
4 years, 8 months ago by prashant.n
Modified:
4 years, 8 months ago
Reviewers:
reveman, vmpstr, ericrk
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@dependency_task
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Refactor OneCopyTileTaskWorkerPool. Move the staging buffer pool related functionalities out to its own file. To isolate the usage of |lock_| from OneCopyTileTaskWorkerPool, the PlaybackAndCopyOnWorkerThread() is splitted into few other functions. PlaybackAndCopyOnWorkerThread() { StagingBufferPool::AcquireStagingBuffer(); // with |lock_| PlaybackToStagingBuffer(); // without |lock_| CopyOnWorkerThread(); // without |lock_|, with context lock StagingBufferPool::ReleaseStagingBuffer(); // with |lock_| } BUG=599863 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/a9dd9effc06a05b417255fe97afd92c3f32d963b Cr-Commit-Position: refs/heads/master@{#386170}

Patch Set 1 #

Patch Set 2 : refactor one copy. #

Total comments: 5

Patch Set 3 : feedback #

Patch Set 4 : nit #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+648 lines, -520 lines) Patch
M cc/BUILD.gn View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M cc/cc.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M cc/raster/one_copy_tile_task_worker_pool.h View 1 2 4 chunks +29 lines, -85 lines 0 comments Download
M cc/raster/one_copy_tile_task_worker_pool.cc View 1 2 3 4 7 chunks +73 lines, -435 lines 0 comments Download
A cc/raster/staging_buffer_pool.h View 1 1 chunk +117 lines, -0 lines 0 comments Download
A cc/raster/staging_buffer_pool.cc View 1 1 chunk +425 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 24 (13 generated)
prashant.n
Kindly give opinion on this.
4 years, 8 months ago (2016-04-05 12:55:30 UTC) #4
prashant.n
ptal
4 years, 8 months ago (2016-04-06 06:31:00 UTC) #6
vmpstr
This looks fine to me, but one of reveman or ericrk should take a look ...
4 years, 8 months ago (2016-04-06 17:53:01 UTC) #8
ericrk
lgtm Seems reasonable to me. Just one nit. https://codereview.chromium.org/1861623003/diff/20001/cc/raster/one_copy_tile_task_worker_pool.cc File cc/raster/one_copy_tile_task_worker_pool.cc (right): https://codereview.chromium.org/1861623003/diff/20001/cc/raster/one_copy_tile_task_worker_pool.cc#newcode353 cc/raster/one_copy_tile_task_worker_pool.cc:353: // ...
4 years, 8 months ago (2016-04-07 19:53:48 UTC) #9
prashant.n
https://codereview.chromium.org/1861623003/diff/20001/cc/raster/one_copy_tile_task_worker_pool.cc File cc/raster/one_copy_tile_task_worker_pool.cc (right): https://codereview.chromium.org/1861623003/diff/20001/cc/raster/one_copy_tile_task_worker_pool.cc#newcode353 cc/raster/one_copy_tile_task_worker_pool.cc:353: // Increment |bytes_scheduled_since_last_flush_| by the amount of memory On ...
4 years, 8 months ago (2016-04-08 16:33:16 UTC) #10
prashant.n
https://codereview.chromium.org/1861623003/diff/20001/cc/raster/staging_buffer_pool.cc File cc/raster/staging_buffer_pool.cc (right): https://codereview.chromium.org/1861623003/diff/20001/cc/raster/staging_buffer_pool.cc#newcode5 cc/raster/staging_buffer_pool.cc:5: #include "cc/raster/staging_buffer_pool.h" Should this be in cc/resources OR cc/raster ...
4 years, 8 months ago (2016-04-08 16:58:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861623003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861623003/60001
4 years, 8 months ago (2016-04-08 17:48:24 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/16365) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-04-08 17:51:12 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861623003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861623003/80001
4 years, 8 months ago (2016-04-08 18:25:31 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-08 19:57:40 UTC) #22
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 20:01:50 UTC) #24
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/a9dd9effc06a05b417255fe97afd92c3f32d963b
Cr-Commit-Position: refs/heads/master@{#386170}

Powered by Google App Engine
This is Rietveld 408576698