Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1286463003: fixup! cc: Handle overflow/underflow in MathUtil::RoundUp/RoundDown (Closed)

Created:
5 years, 4 months ago by prashant.n
Modified:
5 years, 4 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

fixup! cc: Handle overflow/underflow in MathUtil::RoundUp/RoundDown functions. Simple grammatical correction in function names of RoundUpOverflow and RoundDownUnderflow. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/46870db8aa58a80d547ea204a5675fb862066620 Cr-Commit-Position: refs/heads/master@{#342788}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M cc/base/math_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
prashant.n
PTAL.
5 years, 4 months ago (2015-08-10 15:08:12 UTC) #2
vmpstr
lgtm
5 years, 4 months ago (2015-08-10 17:21:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286463003/1
5 years, 4 months ago (2015-08-11 04:34:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-11 05:13:00 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 05:13:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46870db8aa58a80d547ea204a5675fb862066620
Cr-Commit-Position: refs/heads/master@{#342788}

Powered by Google App Engine
This is Rietveld 408576698