Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 2391893003: base: Update comment for ConditionVariable::Wait() function. (Closed)

Created:
4 years, 2 months ago by prashant.n
Modified:
4 years, 2 months ago
Reviewers:
danakj, reveman
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Update comment for ConditionVariable::Wait() function. Currently it sounds like Wait() will return only iff the CV is signaled. But as wait functions are susceptible to spurious wakeups, it may make them singalled before actual signal gets triggered. BUG=None Committed: https://crrev.com/712879f1db853f1d31fd39647c4c3674fee37514 Cr-Commit-Position: refs/heads/master@{#423057}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M base/synchronization/condition_variable.h View 1 chunk +4 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
prashant.n
ptal.
4 years, 2 months ago (2016-10-04 10:04:34 UTC) #2
danakj
LGTM
4 years, 2 months ago (2016-10-04 20:30:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391893003/1
4 years, 2 months ago (2016-10-04 20:30:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/237598)
4 years, 2 months ago (2016-10-04 22:32:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391893003/1
4 years, 2 months ago (2016-10-05 01:46:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 02:48:25 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 02:51:15 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/712879f1db853f1d31fd39647c4c3674fee37514
Cr-Commit-Position: refs/heads/master@{#423057}

Powered by Google App Engine
This is Rietveld 408576698