chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc - Issue 1149263003: Add user_gesture param to BaseWindow::Activate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

Issue 1149263003: Add user_gesture param to BaseWindow::Activate Base URL: https://chromium.googlesource.com/chromium/src.git@ug2_WebContentsDelegate_ActivateContents

Patch Set: Update callers Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_focus_uitest.cc ('K') | « chrome/browser/ui/views/frame/browser_view.cc ('k') | chrome/browser/ui/views/tabs/tab_drag_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

index 2100e8046a0b333dca4aaec1b39b4dddc49f8f5c..a1a9a1908f9344b1dc47f58e253a0ea4c0ab3cf0 100644

--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc

@@ -391,7 +391,7 @@ IN_PROC_BROWSER_TEST_F(ManagePasswordsBubbleViewTest, AutoSigninNoFocus) {

// Bring the first window back. The toast closes by timeout.

focused_window->window()->Close();

- browser()->window()->Activate();

+ browser()->window()->Activate(false /* user_gesture */);

content::RunAllPendingInMessageLoop();

EXPECT_TRUE(browser()->window()->IsActive());

EXPECT_FALSE(IsBubbleShowing());