Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6773)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 1149263003: Add user_gesture param to BaseWindow::Activate Base URL: https://chromium.googlesource.com/chromium/src.git@ug2_WebContentsDelegate_ActivateContents
Patch Set: Update callers Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index 89365884465f36be36c9ddc76ca99de2d07da536..1687abfddb85ffb11e21ca53301c9da052280247 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -721,7 +721,8 @@ void BrowserView::Close() {
frame_->Close();
}
-void BrowserView::Activate() {
+void BrowserView::Activate(bool user_gesture) {
+ // TODO(johnme): Pass user_gesture to Activate.
frame_->Activate();
}
@@ -2555,7 +2556,8 @@ void BrowserView::ActivateAppModalDialog() const {
chrome::FindBrowserWithWebContents(active_dialog->web_contents());
if (modal_browser && (browser_ != modal_browser)) {
modal_browser->window()->FlashFrame(true);
- modal_browser->window()->Activate();
+ // TODO(johnme): Can we sometimes be certain this was for a user gesture?
+ modal_browser->window()->Activate(false /* user_gesture */);
}
app_modal::AppModalDialogQueue::GetInstance()->ActivateModalDialog();

Powered by Google App Engine
This is Rietveld 408576698