chrome/browser/ui/views/frame/browser_view.cc - Issue 1149263003: Add user_gesture param to BaseWindow::Activate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 1149263003: Add user_gesture param to BaseWindow::Activate Base URL: https://chromium.googlesource.com/chromium/src.git@ug2_WebContentsDelegate_ActivateContents

Patch Set: Update callers Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_focus_uitest.cc ('K') | « chrome/browser/ui/views/frame/browser_view.h ('k') | chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index 89365884465f36be36c9ddc76ca99de2d07da536..1687abfddb85ffb11e21ca53301c9da052280247 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -721,7 +721,8 @@ void BrowserView::Close() {

frame_->Close();

}

-void BrowserView::Activate() {

+void BrowserView::Activate(bool user_gesture) {

+ // TODO(johnme): Pass user_gesture to Activate.

frame_->Activate();

}

@@ -2555,7 +2556,8 @@ void BrowserView::ActivateAppModalDialog() const {

chrome::FindBrowserWithWebContents(active_dialog->web_contents());

if (modal_browser && (browser_ != modal_browser)) {

modal_browser->window()->FlashFrame(true);

- modal_browser->window()->Activate();

+ // TODO(johnme): Can we sometimes be certain this was for a user gesture?

+ modal_browser->window()->Activate(false /* user_gesture */);

}

app_modal::AppModalDialogQueue::GetInstance()->ActivateModalDialog();