Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7610)

Unified Diff: chrome/browser/ui/extensions/application_launch.cc

Issue 1149263003: Add user_gesture param to BaseWindow::Activate Base URL: https://chromium.googlesource.com/chromium/src.git@ug2_WebContentsDelegate_ActivateContents
Patch Set: Update callers Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/application_launch.cc
diff --git a/chrome/browser/ui/extensions/application_launch.cc b/chrome/browser/ui/extensions/application_launch.cc
index 996d3ff483116f5f8b1fe11f8b48db20294c78d6..fa51e7a1d851a08423dd5caca820ff73e9dd02f5 100644
--- a/chrome/browser/ui/extensions/application_launch.cc
+++ b/chrome/browser/ui/extensions/application_launch.cc
@@ -239,7 +239,8 @@ WebContents* OpenApplicationTab(const AppLaunchParams& launch_params,
} else {
// For existing browser, ensure its window is shown and activated.
browser->window()->Show();
- browser->window()->Activate();
+ // TODO(johnme): Can we sometimes be certain this was for a user gesture?
+ browser->window()->Activate(false /* user_gesture */);
}
extensions::LaunchType launch_type =

Powered by Google App Engine
This is Rietveld 408576698