Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 1149263003: Add user_gesture param to BaseWindow::Activate Base URL: https://chromium.googlesource.com/chromium/src.git@ug2_WebContentsDelegate_ActivateContents
Patch Set: Update callers Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_window.cc
diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc
index 55e72ab99c46fed4366b0ad85c7ed71eb5837ea3..be3d792c58170e0893cff605191894cd52f774fe 100644
--- a/chrome/browser/devtools/devtools_window.cc
+++ b/chrome/browser/devtools/devtools_window.cc
@@ -828,7 +828,7 @@ void DevToolsWindow::ActivateContents(WebContents* contents,
inspected_tab->GetDelegate()->ActivateContents(inspected_tab,
true /* user_gesture */);
} else if (browser_) {
- browser_->window()->Activate();
+ browser_->window()->Activate(true /* user_gesture */);
}
}
@@ -973,7 +973,7 @@ void DevToolsWindow::ActivateWindow() {
if (is_docked_ && GetInspectedBrowserWindow())
main_web_contents_->Focus();
else if (!is_docked_ && !browser_->window()->IsActive())
- browser_->window()->Activate();
+ browser_->window()->Activate(true /* user_gesture */);
}
void DevToolsWindow::CloseWindow() {
« no previous file with comments | « no previous file | chrome/browser/extensions/api/tabs/tabs_api.cc » ('j') | chrome/browser/ui/browser_focus_uitest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698