extensions/browser/api/app_current_window_internal/app_current_window_internal_api.cc - Issue 1149263003: Add user_gesture param to BaseWindow::Activate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/app_current_window_internal/app_current_window_internal_api.cc

Issue 1149263003: Add user_gesture param to BaseWindow::Activate Base URL: https://chromium.googlesource.com/chromium/src.git@ug2_WebContentsDelegate_ActivateContents

Patch Set: Update callers Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_focus_uitest.cc ('K') | « chrome/test/base/test_browser_window.h ('k') | extensions/components/native_app_window/native_app_window_views.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/app_current_window_internal/app_current_window_internal_api.cc

diff --git a/extensions/browser/api/app_current_window_internal/app_current_window_internal_api.cc b/extensions/browser/api/app_current_window_internal/app_current_window_internal_api.cc

index 0248f4baf61370a5ac4b1b9b595181fde185fa8f..c13710bd1ad2c19a3df92595455670d2b921d054 100644

--- a/extensions/browser/api/app_current_window_internal/app_current_window_internal_api.cc

+++ b/extensions/browser/api/app_current_window_internal/app_current_window_internal_api.cc

@@ -139,7 +139,7 @@ bool AppCurrentWindowInternalExtensionFunction::RunSync() {

}

bool AppCurrentWindowInternalFocusFunction::RunWithWindow(AppWindow* window) {

- window->GetBaseWindow()->Activate();

+ window->GetBaseWindow()->Activate(user_gesture());

return true;

}