chrome/browser/sessions/session_restore.cc - Issue 1149263003: Add user_gesture param to BaseWindow::Activate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sessions/session_restore.cc

Issue 1149263003: Add user_gesture param to BaseWindow::Activate Base URL: https://chromium.googlesource.com/chromium/src.git@ug2_WebContentsDelegate_ActivateContents

Patch Set: Update callers Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/profiles/profile_window.cc ('k') | chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc » ('j') | chrome/browser/ui/browser_focus_uitest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sessions/session_restore.cc

diff --git a/chrome/browser/sessions/session_restore.cc b/chrome/browser/sessions/session_restore.cc

index c6692162035c06fdb0cb02d7c1b7714f178e2d53..396d7bc9089ea37ea39b1aafda4e11e2d0d2d576 100644

--- a/chrome/browser/sessions/session_restore.cc

+++ b/chrome/browser/sessions/session_restore.cc

@@ -457,8 +457,10 @@ class SessionRestoreImpl : public content::NotificationObserver {

chromeos::BootTimesRecorder::Get()->AddLoginTimeMarker(

"SessionRestore-CreatingTabs-End", false);

#endif

- if (browser_to_activate)

- browser_to_activate->window()->Activate();

+ if (browser_to_activate) {

+ // TODO(johnme): Can we sometimes be certain this was for a user gesture?

+ browser_to_activate->window()->Activate(false /* user_gesture */);

+ }

// If last_browser is NULL and urls_to_open_ is non-empty,

// FinishedTabCreation will create a new TabbedBrowser and add the urls to