Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1170)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.cc

Issue 1149263003: Add user_gesture param to BaseWindow::Activate Base URL: https://chromium.googlesource.com/chromium/src.git@ug2_WebContentsDelegate_ActivateContents
Patch Set: Update callers Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/devtools_window.cc ('k') | chrome/browser/profiles/profile_window.cc » ('j') | chrome/browser/ui/browser_focus_uitest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/tabs/tabs_api.cc
diff --git a/chrome/browser/extensions/api/tabs/tabs_api.cc b/chrome/browser/extensions/api/tabs/tabs_api.cc
index 2224bcfd7e67913dd3840938cad7df5ba147e41e..580cac63b5e285204666dbac80a725b8a6552007 100644
--- a/chrome/browser/extensions/api/tabs/tabs_api.cc
+++ b/chrome/browser/extensions/api/tabs/tabs_api.cc
@@ -771,7 +771,7 @@ bool WindowsUpdateFunction::RunSync() {
error_ = keys::kInvalidWindowStateError;
return false;
}
- controller->window()->Activate();
+ controller->window()->Activate(user_gesture());
} else {
if (show_state == ui::SHOW_STATE_MAXIMIZED ||
show_state == ui::SHOW_STATE_FULLSCREEN) {
« no previous file with comments | « chrome/browser/devtools/devtools_window.cc ('k') | chrome/browser/profiles/profile_window.cc » ('j') | chrome/browser/ui/browser_focus_uitest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698