Add user_gesture param to BaseWindow::Activate

chrome/browser/ui/panels/panel_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/devtools/devtools_window.h"
@@ skipping 936 matching lines @@
 IN_PROC_BROWSER_TEST_F(PanelBrowserTest, ActivatePanelOrTabbedWindow) {
   if (!WmSupportWindowActivation()) {
     LOG(WARNING) << "Skipping test due to WM problems.";
     return;
   }
 
   Panel* panel1 = CreatePanel("Panel1");
   Panel* panel2 = CreatePanel("Panel2");
 
   // Activate main tabbed window.
-  browser()->window()->Activate();
+  browser()->window()->Activate(false /* user_gesture */);
   WaitForPanelActiveState(panel2, SHOW_AS_INACTIVE);
 
   // Activate a panel.
-  panel2->Activate();
+  panel2->Activate(false /* user_gesture */);
   WaitForPanelActiveState(panel2, SHOW_AS_ACTIVE);
 
   // Activate the main tabbed window back.
-  browser()->window()->Activate();
+  browser()->window()->Activate(false /* user_gesture */);
   WaitForPanelActiveState(panel2, SHOW_AS_INACTIVE);
 
   // Activate another panel.
-  panel1->Activate();
+  panel1->Activate(false /* user_gesture */);
   WaitForPanelActiveState(panel1, SHOW_AS_ACTIVE);
   WaitForPanelActiveState(panel2, SHOW_AS_INACTIVE);
 
   // Switch focus between panels.
-  panel2->Activate();
+  panel2->Activate(false /* user_gesture */);
   WaitForPanelActiveState(panel2, SHOW_AS_ACTIVE);
   WaitForPanelActiveState(panel1, SHOW_AS_INACTIVE);
 
   PanelManager::GetInstance()->CloseAll();
 }
 
 // TODO(jianli): To be enabled for other platforms.
 #if defined(OS_WIN) || defined(OS_LINUX)
 #define MAYBE_ActivateDeactivateBasic ActivateDeactivateBasic
 #else
@@ skipping 44 matching lines @@
 
   std::vector<bool> expected_active_states;
   std::vector<bool> last_active_states;
 
   // The last created panel, P3, should be active.
   expected_active_states = ProduceExpectedActiveStates(3);
   EXPECT_EQ(expected_active_states, GetAllPanelActiveStates());
   EXPECT_FALSE(tabbed_window->IsActive());
 
   // Activating P1 should cause P3 to lose focus.
-  panels[1]->Activate();
+  panels[1]->Activate(false /* user_gesture */);
   last_active_states = expected_active_states;
   expected_active_states = ProduceExpectedActiveStates(1);
   WaitForPanelActiveStates(last_active_states, expected_active_states);
   EXPECT_EQ(expected_active_states, GetAllPanelActiveStates());
 
   // Minimizing inactive panel P2 should not affect other panels' active states.
   panels[2]->SetExpansionState(Panel::MINIMIZED);
   EXPECT_EQ(expected_active_states, GetAllPanelActiveStates());
   EXPECT_FALSE(tabbed_window->IsActive());
 }
@@ skipping 55 matching lines @@
   MoveMouse(hover_point);
   EXPECT_EQ(Panel::TITLE_ONLY, panel1->expansion_state());
   EXPECT_EQ(Panel::MINIMIZED, panel2->expansion_state());
 
   // Test that we cannot bring down the panel that is drawing the attention.
   hover_point.set_y(hover_point.y() - 200);
   MoveMouse(hover_point);
   EXPECT_EQ(Panel::TITLE_ONLY, panel1->expansion_state());
 
   // Test that the attention is cleared when activated.
-  panel1->Activate();
+  panel1->Activate(false /* user_gesture */);
   WaitForPanelActiveState(panel1, SHOW_AS_ACTIVE);
   EXPECT_FALSE(panel1->IsDrawingAttention());
   EXPECT_EQ(Panel::EXPANDED, panel1->expansion_state());
   EXPECT_FALSE(native_panel1_testing->VerifyDrawingAttention());
 
   PanelManager::GetInstance()->CloseAll();
 }
 
 // Verify that minimized state of a panel is correct after draw attention
 // is stopped when there are other minimized panels.
@@ skipping 84 matching lines @@
 IN_PROC_BROWSER_TEST_F(PanelBrowserTest, DrawAttentionResetOnActivate) {
   Panel* panel = CreateInactivePanel("P1");
   scoped_ptr<NativePanelTesting> native_panel_testing(
       CreateNativePanelTesting(panel));
 
   panel->FlashFrame(true);
   EXPECT_TRUE(panel->IsDrawingAttention());
   EXPECT_TRUE(native_panel_testing->VerifyDrawingAttention());
 
   // Test that the attention is cleared when panel gets focus.
-  panel->Activate();
+  panel->Activate(false /* user_gesture */);
   WaitForPanelActiveState(panel, SHOW_AS_ACTIVE);
   EXPECT_FALSE(panel->IsDrawingAttention());
   EXPECT_FALSE(native_panel_testing->VerifyDrawingAttention());
 
   panel->Close();
 }
 
 IN_PROC_BROWSER_TEST_F(PanelBrowserTest,
                        DrawAttentionMinimizedNotResetOnActivate) {
   Panel* panel = CreateInactivePanel("P1");
@@ skipping 77 matching lines @@
 
   PanelActiveStateObserver signal(panel, false);
   panel->Minimize();
   signal.Wait();
   panel->Close();
 }
 
 IN_PROC_BROWSER_TEST_F(PanelBrowserTest, CreateInactiveSwitchToActive) {
   Panel* panel = CreateInactivePanel("1");
 
-  panel->Activate();
+  panel->Activate(false /* user_gesture */);
   WaitForPanelActiveState(panel, SHOW_AS_ACTIVE);
 
   panel->Close();
 }
 
 // TODO(dimich): try/enable on other platforms. See bug 103253 for details on
 // why this is disabled on windows.
 #if defined(OS_MACOSX)
 #define MAYBE_MinimizeTwoPanelsWithoutTabbedWindow \
     MinimizeTwoPanelsWithoutTabbedWindow
@@ skipping 12 matching lines @@
 
   // Close main tabbed window.
   content::WindowedNotificationObserver signal(
       chrome::NOTIFICATION_BROWSER_CLOSED,
       content::Source<Browser>(browser()));
   chrome::CloseWindow(browser());
   signal.Wait();
 
   EXPECT_EQ(Panel::EXPANDED, panel1->expansion_state());
   EXPECT_EQ(Panel::EXPANDED, panel2->expansion_state());
-  panel1->Activate();
+  panel1->Activate(false /* user_gesture */);
   WaitForPanelActiveState(panel1, SHOW_AS_ACTIVE);
 
   panel1->SetExpansionState(Panel::MINIMIZED);
   base::MessageLoop::current()->RunUntilIdle();
   WaitForPanelActiveState(panel1, SHOW_AS_INACTIVE);
   EXPECT_EQ(Panel::MINIMIZED, panel1->expansion_state());
 
   panel2->SetExpansionState(Panel::MINIMIZED);
   base::MessageLoop::current()->RunUntilIdle();
   WaitForPanelActiveState(panel2, SHOW_AS_INACTIVE);
@@ skipping 410 matching lines @@
 #else
 #define MAYBE_FocusChangeEventOnMinimize FocusChangeEventOnMinimize
 #endif
 IN_PROC_BROWSER_TEST_F(PanelExtensionApiTest,
                        MAYBE_FocusChangeEventOnMinimize) {
   // This is needed so the subsequently created panels can be activated.
   // On a Mac, it transforms background-only test process into foreground one.
   ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
   ASSERT_TRUE(RunExtensionTest("panels/focus_change_on_minimize")) << message_;
 }