Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1029993002: Revert of pathops version two (Closed)

Created:
5 years, 9 months ago by reed1
Modified:
5 years, 9 months ago
Reviewers:
caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of pathops version two (patchset #16 id:150001 of https://codereview.chromium.org/1002693002/) Reason for revert: ASAN investigation Original issue's description: > pathops version two > > R=reed@google.com > > marked 'no commit' to attempt to get trybots to run > > TBR=reed@google.com > > Committed: https://skia.googlesource.com/skia/+/ccec0f958ffc71a9986d236bc2eb335cb2111119 TBR=caryclark@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/0dc4dd6dda9a7912f696b46d9c02155ec1d1ba5f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14270 lines, -13018 lines) Patch
M gyp/core.gypi View 3 chunks +8 lines, -10 lines 0 comments Download
A gyp/pathops.gypi View 1 chunk +61 lines, -0 lines 0 comments Download
M gyp/pathops_unittest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/pathops_unittest.gypi View 3 chunks +5 lines, -7 lines 0 comments Download
M include/pathops/SkPathOps.h View 3 chunks +1 line, -31 lines 0 comments Download
M src/pathops/SkAddIntersections.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/pathops/SkAddIntersections.cpp View 7 chunks +117 lines, -70 lines 0 comments Download
A src/pathops/SkDCubicIntersection.cpp View 1 chunk +704 lines, -0 lines 0 comments Download
M src/pathops/SkDCubicLineIntersection.cpp View 5 chunks +34 lines, -58 lines 0 comments Download
M src/pathops/SkDCubicToQuads.cpp View 2 chunks +150 lines, -0 lines 0 comments Download
M src/pathops/SkDLineIntersection.cpp View 7 chunks +81 lines, -3 lines 0 comments Download
A src/pathops/SkDQuadImplicit.h View 1 chunk +39 lines, -0 lines 0 comments Download
A src/pathops/SkDQuadImplicit.cpp View 1 chunk +117 lines, -0 lines 0 comments Download
A src/pathops/SkDQuadIntersection.cpp View 1 chunk +617 lines, -0 lines 0 comments Download
M src/pathops/SkDQuadLineIntersection.cpp View 4 chunks +16 lines, -62 lines 0 comments Download
M src/pathops/SkIntersectionHelper.h View 5 chunks +73 lines, -20 lines 0 comments Download
M src/pathops/SkIntersections.h View 11 chunks +62 lines, -27 lines 0 comments Download
M src/pathops/SkIntersections.cpp View 6 chunks +74 lines, -78 lines 0 comments Download
M src/pathops/SkOpAngle.h View 3 chunks +106 lines, -81 lines 0 comments Download
M src/pathops/SkOpAngle.cpp View 31 chunks +366 lines, -411 lines 0 comments Download
M src/pathops/SkOpCoincidence.h View 2 chunks +2 lines, -18 lines 0 comments Download
D src/pathops/SkOpCoincidence.cpp View 1 chunk +0 lines, -388 lines 0 comments Download
M src/pathops/SkOpContour.h View 2 chunks +310 lines, -300 lines 0 comments Download
M src/pathops/SkOpContour.cpp View 3 chunks +696 lines, -46 lines 0 comments Download
M src/pathops/SkOpEdgeBuilder.h View 3 chunks +13 lines, -26 lines 0 comments Download
M src/pathops/SkOpEdgeBuilder.cpp View 10 chunks +35 lines, -69 lines 0 comments Download
M src/pathops/SkOpSegment.h View 1 chunk +531 lines, -347 lines 0 comments Download
M src/pathops/SkOpSegment.cpp View 39 chunks +3933 lines, -1115 lines 0 comments Download
M src/pathops/SkOpSpan.h View 1 chunk +21 lines, -445 lines 0 comments Download
D src/pathops/SkOpSpan.cpp View 1 chunk +0 lines, -355 lines 0 comments Download
M src/pathops/SkOpTAllocator.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/pathops/SkPathOpsCommon.h View 1 chunk +11 lines, -15 lines 0 comments Download
M src/pathops/SkPathOpsCommon.cpp View 17 chunks +338 lines, -276 lines 0 comments Download
M src/pathops/SkPathOpsCubic.h View 6 chunks +15 lines, -52 lines 0 comments Download
M src/pathops/SkPathOpsCubic.cpp View 7 chunks +71 lines, -120 lines 0 comments Download
A src/pathops/SkPathOpsCubicSect.h View 1 chunk +175 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsDebug.h View 5 chunks +106 lines, -126 lines 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 6 chunks +437 lines, -344 lines 0 comments Download
M src/pathops/SkPathOpsLine.h View 1 chunk +10 lines, -3 lines 0 comments Download
M src/pathops/SkPathOpsLine.cpp View 3 chunks +21 lines, -1 line 0 comments Download
M src/pathops/SkPathOpsOp.cpp View 9 chunks +111 lines, -79 lines 0 comments Download
M src/pathops/SkPathOpsPoint.h View 6 chunks +51 lines, -20 lines 0 comments Download
M src/pathops/SkPathOpsPostSect.cpp View 10 chunks +12 lines, -15 lines 0 comments Download
M src/pathops/SkPathOpsQuad.h View 2 chunks +8 lines, -27 lines 0 comments Download
M src/pathops/SkPathOpsQuad.cpp View 5 chunks +14 lines, -61 lines 0 comments Download
A src/pathops/SkPathOpsQuadSect.h View 1 chunk +175 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsRect.h View 3 chunks +19 lines, -11 lines 0 comments Download
M src/pathops/SkPathOpsRect.cpp View 3 chunks +19 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsSimplify.cpp View 6 chunks +62 lines, -99 lines 0 comments Download
M src/pathops/SkPathOpsTCubicSect.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/pathops/SkPathOpsTQuadSect.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/pathops/SkPathOpsTSect.h View 24 chunks +545 lines, -1251 lines 0 comments Download
M src/pathops/SkPathOpsTightBounds.cpp View 1 chunk +5 lines, -7 lines 0 comments Download
A src/pathops/SkPathOpsTriangle.h View 1 chunk +20 lines, -0 lines 0 comments Download
A src/pathops/SkPathOpsTriangle.cpp View 1 chunk +51 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsTypes.h View 6 chunks +8 lines, -121 lines 0 comments Download
A src/pathops/SkQuarticRoot.h View 1 chunk +16 lines, -0 lines 0 comments Download
A src/pathops/SkQuarticRoot.cpp View 1 chunk +168 lines, -0 lines 0 comments Download
M src/pathops/SkReduceOrder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/pathops/SkReduceOrder.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M tests/PathOpsAngleIdeas.cpp View 5 chunks +26 lines, -29 lines 0 comments Download
M tests/PathOpsAngleTest.cpp View 8 chunks +89 lines, -101 lines 0 comments Download
M tests/PathOpsBattles.cpp View 20 chunks +25 lines, -20 lines 0 comments Download
M tests/PathOpsBuilderTest.cpp View 4 chunks +2 lines, -9 lines 0 comments Download
M tests/PathOpsCubicIntersectionTest.cpp View 7 chunks +54 lines, -164 lines 0 comments Download
M tests/PathOpsCubicIntersectionTestData.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M tests/PathOpsCubicLineIntersectionTest.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/PathOpsCubicQuadIntersectionTest.cpp View 4 chunks +223 lines, -10 lines 0 comments Download
A tests/PathOpsCubicToQuadsTest.cpp View 1 chunk +198 lines, -0 lines 0 comments Download
M tests/PathOpsDLineTest.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/PathOpsDPointTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A tests/PathOpsDQuadTest.cpp View 1 chunk +63 lines, -0 lines 0 comments Download
M tests/PathOpsDRectTest.cpp View 3 chunks +47 lines, -17 lines 0 comments Download
A tests/PathOpsDTriangleTest.cpp View 1 chunk +70 lines, -0 lines 0 comments Download
M tests/PathOpsDebug.cpp View 9 chunks +635 lines, -937 lines 0 comments Download
M tests/PathOpsExtendedTest.h View 4 chunks +1 line, -6 lines 0 comments Download
M tests/PathOpsExtendedTest.cpp View 17 chunks +33 lines, -49 lines 0 comments Download
M tests/PathOpsFuzz763Test.cpp View 21 chunks +33 lines, -32 lines 0 comments Download
M tests/PathOpsLineIntersectionTest.cpp View 11 chunks +15 lines, -28 lines 0 comments Download
M tests/PathOpsOpCubicThreadedTest.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M tests/PathOpsOpLoopThreadedTest.cpp View 4 chunks +10 lines, -35 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 29 chunks +41 lines, -349 lines 0 comments Download
M tests/PathOpsQuadIntersectionTest.cpp View 6 chunks +13 lines, -73 lines 0 comments Download
M tests/PathOpsQuadIntersectionTestData.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
A tests/PathOpsQuadParameterizationTest.cpp View 1 chunk +50 lines, -0 lines 0 comments Download
M tests/PathOpsSimplifyFailTest.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M tests/PathOpsSimplifyTest.cpp View 5 chunks +9 lines, -8 lines 0 comments Download
M tests/PathOpsSkpTest.cpp View 41 chunks +84 lines, -37 lines 0 comments Download
M tests/PathOpsTSectDebug.h View 1 chunk +47 lines, -128 lines 0 comments Download
M tests/PathOpsTestCommon.h View 1 chunk +1 line, -0 lines 0 comments Download
M tests/PathOpsTestCommon.cpp View 2 chunks +11 lines, -120 lines 0 comments Download
M tests/PathOpsThreeWayTest.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M tests/PathOpsTightBoundsTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/pathops_sorter.htm View 14 chunks +1178 lines, -357 lines 0 comments Download
M tools/pathops_visualizer.htm View 35 chunks +635 lines, -3864 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
reed1
Created Revert of pathops version two
5 years, 9 months ago (2015-03-24 20:54:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029993002/1
5 years, 9 months ago (2015-03-24 20:54:36 UTC) #2
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 20:55:38 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0dc4dd6dda9a7912f696b46d9c02155ec1d1ba5f

Powered by Google App Engine
This is Rietveld 408576698