Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1009543004: Create a Perspective enum to use instead of a bool is_server to improve (Closed)

Created:
5 years, 9 months ago by ramant (doing other things)
Modified:
5 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create a Perspective enum to use instead of a bool is_server to improve readability. This also replaces the CryptoUtils::Perspective enun. Merge internal change: 88006458 R=rch@chromium.org Committed: https://crrev.com/6f48aa977c765198ef16a9524f00ff97e35500c5 Cr-Commit-Position: refs/heads/master@{#320694}

Patch Set 1 #

Patch Set 2 : Added NET_EXPORT_PRIVATE to fix compiler error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -294 lines) Patch
M net/quic/congestion_control/pacing_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/pacing_sender.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/congestion_control/send_algorithm_interface.h View 1 chunk +3 lines, -2 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_test.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M net/quic/crypto/crypto_utils.h View 1 chunk +0 lines, -5 lines 0 comments Download
M net/quic/crypto/crypto_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/crypto/quic_crypto_client_config.cc View 3 chunks +12 lines, -13 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 3 chunks +9 lines, -10 lines 0 comments Download
M net/quic/quic_client_session_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_connection.h View 4 chunks +5 lines, -5 lines 0 comments Download
M net/quic/quic_connection.cc View 10 chunks +16 lines, -13 lines 0 comments Download
M net/quic/quic_connection_logger_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_connection_test.cc View 13 chunks +34 lines, -34 lines 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_crypto_client_stream_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/quic/quic_crypto_stream.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/quic_crypto_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_data_stream.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M net/quic/quic_data_stream_test.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/quic_dispatcher.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M net/quic/quic_flow_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_flow_controller.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M net/quic/quic_flow_controller_test.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/quic/quic_framer.h View 5 chunks +7 lines, -7 lines 0 comments Download
M net/quic/quic_framer.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M net/quic/quic_framer_test.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_headers_stream.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/quic/quic_headers_stream_test.cc View 7 chunks +12 lines, -11 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_packet_creator_test.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M net/quic/quic_packet_generator_test.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/quic_protocol.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/quic_protocol.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M net/quic/quic_reliable_client_stream_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_sent_packet_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M net/quic/quic_session.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_session.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M net/quic/quic_session_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_stream_factory.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M net/quic/quic_stream_sequencer_test.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/quic/reliable_quic_stream.h View 1 chunk +3 lines, -2 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.h View 1 chunk +2 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.cc View 1 chunk +4 lines, -9 lines 0 comments Download
M net/quic/test_tools/quic_framer_peer.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/quic_framer_peer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_test_packet_maker.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 4 chunks +13 lines, -10 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 5 chunks +22 lines, -19 lines 0 comments Download
M net/quic/test_tools/simple_quic_framer.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/tools/quic/quic_client.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream_test.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream_test.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
ramant (doing other things)
5 years, 9 months ago (2015-03-13 23:25:22 UTC) #1
ramant (doing other things)
On 2015/03/13 23:25:22, ramant wrote: Hi Ryan, "git cl format net" changed lot of the ...
5 years, 9 months ago (2015-03-13 23:40:39 UTC) #2
Ryan Hamilton
lgtm
5 years, 9 months ago (2015-03-15 21:10:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009543004/1
5 years, 9 months ago (2015-03-15 23:37:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/52542)
5 years, 9 months ago (2015-03-16 00:43:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1009543004/20001
5 years, 9 months ago (2015-03-16 00:49:47 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-16 02:18:58 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 02:19:48 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6f48aa977c765198ef16a9524f00ff97e35500c5
Cr-Commit-Position: refs/heads/master@{#320694}

Powered by Google App Engine
This is Rietveld 408576698