Create a Perspective enum to use instead of a bool is_server to improve

net/tools/quic/quic_client_session_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/tools/quic/quic_client_session.h"
 
 #include <vector>
 
 #include "net/base/ip_endpoint.h"
 #include "net/quic/crypto/aes_128_gcm_12_encrypter.h"
@@ skipping 21 matching lines @@
 namespace test {
 namespace {
 
 const char kServerHostname[] = "www.example.org";
 const uint16 kPort = 80;
 
 class ToolsQuicClientSessionTest
     : public ::testing::TestWithParam<QuicVersion> {
  protected:
   ToolsQuicClientSessionTest()
-      : connection_(
-            new PacketSavingConnection(false, SupportedVersions(GetParam()))) {
+      : connection_(new PacketSavingConnection(Perspective::IS_CLIENT,
+                                               SupportedVersions(GetParam()))) {
     session_.reset(new QuicClientSession(DefaultQuicConfig(), connection_));
     session_->InitializeSession(
         QuicServerId(kServerHostname, kPort, false, PRIVACY_MODE_DISABLED),
         &crypto_config_);
     // Advance the time, because timers do not like uninitialized times.
     connection_->AdvanceTime(QuicTime::Delta::FromSeconds(1));
   }
 
   void CompleteCryptoHandshake() {
     session_->CryptoConnect();
     CryptoTestUtils::HandshakeWithFakeServer(
         connection_, session_->GetCryptoStream());
   }
 
   PacketSavingConnection* connection_;
   scoped_ptr<QuicClientSession> session_;
   QuicCryptoClientConfig crypto_config_;
 };
 
 INSTANTIATE_TEST_CASE_P(Tests, ToolsQuicClientSessionTest,
                         ::testing::ValuesIn(QuicSupportedVersions()));
 
 TEST_P(ToolsQuicClientSessionTest, CryptoConnect) {
   CompleteCryptoHandshake();
 }
 
 TEST_P(ToolsQuicClientSessionTest, MaxNumStreams) {
   session_->config()->SetMaxStreamsPerConnection(1, 1);
-  // FLAGS_max_streams_per_connection = 1;
+
   // Initialize crypto before the client session will create a stream.
   CompleteCryptoHandshake();
 
   QuicSpdyClientStream* stream = session_->CreateOutgoingDataStream();
   ASSERT_TRUE(stream);
   EXPECT_FALSE(session_->CreateOutgoingDataStream());
 
   // Close a stream and ensure I can now open a new one.
   session_->CloseStream(stream->id());
   stream = session_->CreateOutgoingDataStream();
@@ skipping 53 matching lines @@
   // Close connection shouldn't be called.
   EXPECT_CALL(*connection_, SendConnectionCloseWithDetails(_, _)).Times(0);
   session_->connection()->ProcessUdpPacket(client_address, server_address,
                                            valid_packet);
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace tools
 }  // namespace net