Create a Perspective enum to use instead of a bool is_server to improve

net/quic/quic_headers_stream.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_headers_stream.h"
 
 #include "base/strings/stringprintf.h"
 #include "net/quic/quic_session.h"
 
 using base::StringPiece;
@@ skipping 204 matching lines @@
 QuicHeadersStream::~QuicHeadersStream() {}
 
 size_t QuicHeadersStream::WriteHeaders(
     QuicStreamId stream_id,
     const SpdyHeaderBlock& headers,
     bool fin,
     QuicPriority priority,
     QuicAckNotifier::DelegateInterface* ack_notifier_delegate) {
   scoped_ptr<SpdySerializedFrame> frame;
   if (spdy_framer_->protocol_version() == SPDY3) {
-    if (session()->is_server()) {
+    if (session()->perspective() == Perspective::IS_SERVER) {
       SpdySynReplyIR syn_reply(stream_id);
       syn_reply.set_name_value_block(headers);
       syn_reply.set_fin(fin);
       frame.reset(spdy_framer_->SerializeFrame(syn_reply));
     } else {
       SpdySynStreamIR syn_stream(stream_id);
       syn_stream.set_name_value_block(headers);
       syn_stream.set_fin(fin);
       syn_stream.set_priority(priority);
       frame.reset(spdy_framer_->SerializeFrame(syn_stream));
     }
   } else {
     SpdyHeadersIR headers_frame(stream_id);
     headers_frame.set_name_value_block(headers);
     headers_frame.set_fin(fin);
-    if (!session()->is_server()) {
+    if (session()->perspective() == Perspective::IS_CLIENT) {
       headers_frame.set_has_priority(true);
       headers_frame.set_priority(priority);
     }
     frame.reset(spdy_framer_->SerializeFrame(headers_frame));
   }
   WriteOrBufferData(StringPiece(frame->data(), frame->size()), false,
                     ack_notifier_delegate);
   return frame->size();
 }
 
@@ skipping 16 matching lines @@
   }
   spdy_framer_.reset(new SpdyFramer(spdy_version));
   spdy_framer_visitor_.reset(new SpdyFramerVisitor(spdy_version, this));
   spdy_framer_->set_visitor(spdy_framer_visitor_.get());
   spdy_framer_->set_debug_visitor(spdy_framer_visitor_.get());
 }
 
 void QuicHeadersStream::OnSynStream(SpdyStreamId stream_id,
                                     SpdyPriority priority,
                                     bool fin) {
-  if (!session()->is_server()) {
+  if (session()->perspective() == Perspective::IS_CLIENT) {
     CloseConnectionWithDetails(
         QUIC_INVALID_HEADERS_STREAM_DATA,
         "SPDY SYN_STREAM frame received at the client");
     return;
   }
   DCHECK_EQ(kInvalidStreamId, stream_id_);
   stream_id_ = stream_id;
   fin_ = fin;
   session()->OnStreamHeadersPriority(stream_id, priority);
 }
 
 void QuicHeadersStream::OnSynReply(SpdyStreamId stream_id, bool fin) {
-  if (session()->is_server()) {
+  if (session()->perspective() == Perspective::IS_SERVER) {
     CloseConnectionWithDetails(
         QUIC_INVALID_HEADERS_STREAM_DATA,
         "SPDY SYN_REPLY frame received at the server");
     return;
   }
   DCHECK_EQ(kInvalidStreamId, stream_id_);
   stream_id_ = stream_id;
   fin_ = fin;
 }
 
@@ skipping 22 matching lines @@
     DCHECK_EQ(0u, frame_len_);
   }
   frame_len_ += frame_len;
 }
 
 bool QuicHeadersStream::IsConnected() {
   return session()->connection()->connected();
 }
 
 }  // namespace net