net/quic/crypto/crypto_utils.cc - Issue 1009543004: Create a Perspective enum to use instead of a bool is_server to improve

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/crypto/crypto_utils.cc

Issue 1009543004: Create a Perspective enum to use instead of a bool is_server to improve (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added NET_EXPORT_PRIVATE to fix compiler error Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/crypto/crypto_utils.cc

diff --git a/net/quic/crypto/crypto_utils.cc b/net/quic/crypto/crypto_utils.cc

index c5957750654659225bc2cf0ccf796e7e476cfaaa..0916474f215719459d5f4b9dca8b59a0f6e62035 100644

--- a/net/quic/crypto/crypto_utils.cc

+++ b/net/quic/crypto/crypto_utils.cc

@@ -104,7 +104,7 @@ bool CryptoUtils::DeriveKeys(StringPiece premaster_secret,

crypto::HKDF hkdf(premaster_secret, nonce, hkdf_input, key_bytes,

nonce_prefix_bytes, subkey_secret_bytes);

- if (perspective == SERVER) {

+ if (perspective == Perspective::IS_SERVER) {

if (!crypters->encrypter->SetKey(hkdf.server_write_key()) ||

!crypters->encrypter->SetNoncePrefix(hkdf.server_write_iv()) ||

!crypters->decrypter->SetKey(hkdf.client_write_key()) ||

« no previous file with comments | « net/quic/crypto/crypto_utils.h ('k') | net/quic/crypto/quic_crypto_client_config.cc » ('j') | no next file with comments »