Create a Perspective enum to use instead of a bool is_server to improve

net/quic/quic_data_stream.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_data_stream.h"
 
 #include "base/logging.h"
 #include "net/quic/quic_session.h"
 #include "net/quic/quic_utils.h"
 #include "net/quic/quic_write_blocked_list.h"
 
 using base::StringPiece;
 using std::min;
 
 namespace net {
 
-#define ENDPOINT (session()->is_server() ? "Server: " : " Client: ")
+#define ENDPOINT                                                               \
+  (session()->perspective() == Perspective::IS_SERVER ? "Server: " : "Client:" \
+                                                                     " ")
 
 namespace {
 
 // This is somewhat arbitrary.  It's possible, but unlikely, we will either fail
 // to set a priority client-side, or cancel a stream before stripping the
 // priority from the wire server-side.  In either case, start out with a
 // priority in the middle.
 QuicPriority kDefaultPriority = 3;
 
 }  // namespace
@@ skipping 115 matching lines @@
   }
   return bytes_processed;
 }
 
 void QuicDataStream::OnStreamHeaders(StringPiece headers_data) {
   headers_data.AppendToString(&decompressed_headers_);
   ProcessHeaderData();
 }
 
 void QuicDataStream::OnStreamHeadersPriority(QuicPriority priority) {
-  DCHECK(session()->connection()->is_server());
+  DCHECK_EQ(Perspective::IS_SERVER, session()->connection()->perspective());
   set_priority(priority);
 }
 
 void QuicDataStream::OnStreamHeadersComplete(bool fin, size_t frame_len) {
   headers_decompressed_ = true;
   if (fin) {
     sequencer()->OnStreamFrame(QuicStreamFrame(id(), fin, 0, IOVector()));
   }
   ProcessHeaderData();
   if (FinishedReadingHeaders()) {
@@ skipping 11 matching lines @@
     visitor_ = nullptr;
     visitor->OnClose(this);
   }
 }
 
 bool QuicDataStream::FinishedReadingHeaders() {
   return headers_decompressed_ && decompressed_headers_.empty();
 }
 
 }  // namespace net