net/tools/quic/quic_spdy_server_stream_test.cc - Issue 1009543004: Create a Perspective enum to use instead of a bool is_server to improve

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/quic_spdy_server_stream_test.cc

Issue 1009543004: Create a Perspective enum to use instead of a bool is_server to improve (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added NET_EXPORT_PRIVATE to fix compiler error Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/tools/quic/quic_spdy_server_stream_test.cc

diff --git a/net/tools/quic/quic_spdy_server_stream_test.cc b/net/tools/quic/quic_spdy_server_stream_test.cc

index 1187d3408a525709852e55049872280c66339035..9277a829a943780dfd5f15e11149806bb3a47c70 100644

--- a/net/tools/quic/quic_spdy_server_stream_test.cc

+++ b/net/tools/quic/quic_spdy_server_stream_test.cc

@@ -72,8 +72,9 @@ namespace {

class QuicSpdyServerStreamTest : public ::testing::TestWithParam<QuicVersion> {

public:

QuicSpdyServerStreamTest()

- : connection_(new StrictMock<MockConnection>(

- true, SupportedVersions(GetParam()))),

+ : connection_(

+ new StrictMock<MockConnection>(Perspective::IS_SERVER,

+ SupportedVersions(GetParam()))),

session_(connection_),

body_("hello world") {

BalsaHeaders request_headers;

« no previous file with comments | « net/tools/quic/quic_spdy_client_stream_test.cc ('k') | net/tools/quic/quic_time_wait_list_manager_test.cc » ('j') | no next file with comments »