net/quic/quic_crypto_client_stream.cc - Issue 1009543004: Create a Perspective enum to use instead of a bool is_server to improve

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_crypto_client_stream.cc

Issue 1009543004: Create a Perspective enum to use instead of a bool is_server to improve (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added NET_EXPORT_PRIVATE to fix compiler error Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_crypto_client_stream.cc

diff --git a/net/quic/quic_crypto_client_stream.cc b/net/quic/quic_crypto_client_stream.cc

index eaff5289f4065935a1c1c30a2236cdcc0483aa77..133f4fb93379f6eb24e9cfad753ffef16bad3279 100644

--- a/net/quic/quic_crypto_client_stream.cc

+++ b/net/quic/quic_crypto_client_stream.cc

@@ -88,7 +88,7 @@ QuicCryptoClientStream::QuicCryptoClientStream(

channel_id_source_callback_(nullptr),

verify_context_(verify_context),

proof_verify_callback_(nullptr) {

- DCHECK(!session->connection()->is_server());

+ DCHECK_EQ(Perspective::IS_CLIENT, session->connection()->perspective());

}

QuicCryptoClientStream::~QuicCryptoClientStream() {

« no previous file with comments | « net/quic/quic_connection_test.cc ('k') | net/quic/quic_crypto_client_stream_test.cc » ('j') | no next file with comments »