Create a Perspective enum to use instead of a bool is_server to improve

net/quic/quic_stream_factory.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_stream_factory.h"
 
 #include <set>
 
 #include "base/cpu.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 1061 matching lines @@
     helper_.reset(new QuicConnectionHelper(
         base::MessageLoop::current()->message_loop_proxy().get(),
         clock_.get(), random_generator_));
   }
 
   // TODO(vadimt): Remove ScopedTracker below once crbug.com/422516 is fixed.
   tracked_objects::ScopedTracker tracking_profile4(
       FROM_HERE_WITH_EXPLICIT_FUNCTION(
           "422516 QuicStreamFactory::CreateSession4"));
 
-  QuicConnection* connection = new QuicConnection(connection_id,
-                                                  addr,
-                                                  helper_.get(),
-                                                  packet_writer_factory,
-                                                  true  /* owns_writer */,
-                                                  false  /* is_server */,
-                                                  server_id.is_https(),
-                                                  supported_versions_);
+  QuicConnection* connection = new QuicConnection(
+      connection_id, addr, helper_.get(), packet_writer_factory,
+      true /* owns_writer */, Perspective::IS_CLIENT, server_id.is_https(),
+      supported_versions_);
   connection->set_max_packet_length(max_packet_length_);
 
   // TODO(vadimt): Remove ScopedTracker below once crbug.com/422516 is fixed.
   tracked_objects::ScopedTracker tracking_profile5(
       FROM_HERE_WITH_EXPLICIT_FUNCTION(
           "422516 QuicStreamFactory::CreateSession5"));
 
   InitializeCachedStateInCryptoConfig(server_id, server_info);
 
   // TODO(vadimt): Remove ScopedTracker below once crbug.com/422516 is fixed.
@@ skipping 230 matching lines @@
   // HttpStreamFactoryImpl::Job running which can mark it broken, unless the TCP
   // job also fails. So to avoid not using QUIC when we otherwise could, we mark
   // it as recently broken, which means that 0-RTT will be disabled but we'll
   // still race.
   const HostPortPair& server = server_id.host_port_pair();
   http_server_properties_->MarkAlternativeServiceRecentlyBroken(
       AlternativeService(QUIC, server.host(), server.port()));
 }
 
 }  // namespace net