Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: net/quic/congestion_control/pacing_sender.h

Issue 1009543004: Create a Perspective enum to use instead of a bool is_server to improve (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added NET_EXPORT_PRIVATE to fix compiler error Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/quic/congestion_control/pacing_sender.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // A send algorithm that adds pacing on top of an another send algorithm. 5 // A send algorithm that adds pacing on top of an another send algorithm.
6 // It uses the underlying sender's pacing rate to schedule packets. 6 // It uses the underlying sender's pacing rate to schedule packets.
7 // It also takes into consideration the expected granularity of the underlying 7 // It also takes into consideration the expected granularity of the underlying
8 // alarm to ensure that alarms are not set too aggressively, and err towards 8 // alarm to ensure that alarms are not set too aggressively, and err towards
9 // sending packets too early instead of too late. 9 // sending packets too early instead of too late.
10 10
(...skipping 19 matching lines...) Expand all
30 // indicates to the pacer to send that far into the future, since it should 30 // indicates to the pacer to send that far into the future, since it should
31 // not expect a callback before that time delta. |initial_packet_burst| is 31 // not expect a callback before that time delta. |initial_packet_burst| is
32 // the number of packets sent without pacing after quiescence. 32 // the number of packets sent without pacing after quiescence.
33 PacingSender(SendAlgorithmInterface* sender, 33 PacingSender(SendAlgorithmInterface* sender,
34 QuicTime::Delta alarm_granularity, 34 QuicTime::Delta alarm_granularity,
35 uint32 initial_packet_burst); 35 uint32 initial_packet_burst);
36 ~PacingSender() override; 36 ~PacingSender() override;
37 37
38 // SendAlgorithmInterface methods. 38 // SendAlgorithmInterface methods.
39 void SetFromConfig(const QuicConfig& config, 39 void SetFromConfig(const QuicConfig& config,
40 bool is_server, 40 Perspective perspective,
41 bool using_pacing) override; 41 bool using_pacing) override;
42 bool ResumeConnectionState( 42 bool ResumeConnectionState(
43 const CachedNetworkParameters& cached_network_params) override; 43 const CachedNetworkParameters& cached_network_params) override;
44 void SetNumEmulatedConnections(int num_connections) override; 44 void SetNumEmulatedConnections(int num_connections) override;
45 void OnCongestionEvent(bool rtt_updated, 45 void OnCongestionEvent(bool rtt_updated,
46 QuicByteCount bytes_in_flight, 46 QuicByteCount bytes_in_flight,
47 const CongestionVector& acked_packets, 47 const CongestionVector& acked_packets,
48 const CongestionVector& lost_packets) override; 48 const CongestionVector& lost_packets) override;
49 bool OnPacketSent(QuicTime sent_time, 49 bool OnPacketSent(QuicTime sent_time,
50 QuicByteCount bytes_in_flight, 50 QuicByteCount bytes_in_flight,
(...skipping 28 matching lines...) Expand all
79 QuicTime last_delayed_packet_sent_time_; 79 QuicTime last_delayed_packet_sent_time_;
80 QuicTime ideal_next_packet_send_time_; // When can the next packet be sent. 80 QuicTime ideal_next_packet_send_time_; // When can the next packet be sent.
81 mutable bool was_last_send_delayed_; // True when the last send was delayed. 81 mutable bool was_last_send_delayed_; // True when the last send was delayed.
82 82
83 DISALLOW_COPY_AND_ASSIGN(PacingSender); 83 DISALLOW_COPY_AND_ASSIGN(PacingSender);
84 }; 84 };
85 85
86 } // namespace net 86 } // namespace net
87 87
88 #endif // NET_QUIC_CONGESTION_CONTROL_PACING_SENDER_H_ 88 #endif // NET_QUIC_CONGESTION_CONTROL_PACING_SENDER_H_
OLDNEW
« no previous file with comments | « no previous file | net/quic/congestion_control/pacing_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698