net/quic/congestion_control/tcp_cubic_sender.cc - Issue 1009543004: Create a Perspective enum to use instead of a bool is_server to improve

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/congestion_control/tcp_cubic_sender.cc

Issue 1009543004: Create a Perspective enum to use instead of a bool is_server to improve (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added NET_EXPORT_PRIVATE to fix compiler error Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/congestion_control/tcp_cubic_sender.cc

diff --git a/net/quic/congestion_control/tcp_cubic_sender.cc b/net/quic/congestion_control/tcp_cubic_sender.cc

index 6cfe0fb7b6d7970316997c7fde51ca2c742c4333..5b24a1f25281a8ba952373c262e5ef38bb25de39 100644

--- a/net/quic/congestion_control/tcp_cubic_sender.cc

+++ b/net/quic/congestion_control/tcp_cubic_sender.cc

@@ -53,9 +53,9 @@ TcpCubicSender::~TcpCubicSender() {

}

void TcpCubicSender::SetFromConfig(const QuicConfig& config,

- bool is_server,

+ Perspective perspective,

bool using_pacing) {

- if (is_server) {

+ if (perspective == Perspective::IS_SERVER) {

if (config.HasReceivedConnectionOptions() &&

ContainsQuicTag(config.ReceivedConnectionOptions(), kIW10)) {

// Initial window experiment.

« no previous file with comments | « net/quic/congestion_control/tcp_cubic_sender.h ('k') | net/quic/congestion_control/tcp_cubic_sender_test.cc » ('j') | no next file with comments »