Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: net/quic/quic_data_stream_test.cc

Issue 1009543004: Create a Perspective enum to use instead of a bool is_server to improve (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added NET_EXPORT_PRIVATE to fix compiler error Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_data_stream.cc ('k') | net/quic/quic_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_data_stream_test.cc
diff --git a/net/quic/quic_data_stream_test.cc b/net/quic/quic_data_stream_test.cc
index cc865c095667c2132acba47051575897fe7c77a9..246edc926308af762eb95737fd1a89a3b93fb8f1 100644
--- a/net/quic/quic_data_stream_test.cc
+++ b/net/quic/quic_data_stream_test.cc
@@ -30,7 +30,6 @@ namespace net {
namespace test {
namespace {
-const bool kIsServer = true;
const bool kShouldProcessData = true;
class TestStream : public QuicDataStream {
@@ -93,7 +92,7 @@ class QuicDataStreamTest : public ::testing::TestWithParam<QuicVersion> {
void Initialize(bool stream_should_process_data) {
connection_ = new testing::StrictMock<MockConnection>(
- kIsServer, SupportedVersions(GetParam()));
+ Perspective::IS_SERVER, SupportedVersions(GetParam()));
session_.reset(new testing::StrictMock<MockSession>(connection_));
stream_.reset(new TestStream(kClientDataStreamId1, session_.get(),
stream_should_process_data));
« no previous file with comments | « net/quic/quic_data_stream.cc ('k') | net/quic/quic_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698