Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14251006: Remove AsyncError with Expando. (Closed)

Created:
7 years, 8 months ago by floitsch
Modified:
7 years, 8 months ago
CC:
reviews_dartlang.org, nweiz, srdjan, Jennifer Messerly, Siggi Cherem (dart-lang)
Visibility:
Public.

Description

Remove AsyncError with Expando. Committed: https://code.google.com/p/dart/source/detail?r=21498

Patch Set 1 #

Patch Set 2 : Remove AsyncError and fix unittest. #

Patch Set 3 : With Anders' patch applied. #

Patch Set 4 : Rebuild DOM and rebase. #

Total comments: 6

Patch Set 5 : Fixes and status file updates. #

Patch Set 6 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+878 lines, -843 lines) Patch
M pkg/http/lib/src/utils.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/http/test/request_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/http/test/safe_http_server.dart View 1 2 3 4 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/oauth2/test/authorization_code_grant_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/oauth2/test/client_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/oauth2/test/credentials_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/scheduled_test/lib/scheduled_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/scheduled_test/lib/src/descriptor/directory_descriptor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/scheduled_test/lib/src/descriptor/pattern_descriptor.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/scheduled_test/lib/src/future_group.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/scheduled_test/lib/src/schedule.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/scheduled_test/lib/src/schedule_error.dart View 1 2 3 chunks +21 lines, -16 lines 0 comments Download
M pkg/scheduled_test/lib/src/scheduled_future_matchers.dart View 1 chunk +4 lines, -5 lines 0 comments Download
M pkg/scheduled_test/lib/src/scheduled_server/safe_http_server.dart View 1 2 3 4 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/scheduled_test/lib/src/substitute_future.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/scheduled_test/lib/src/utils.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M pkg/scheduled_test/lib/src/value_future.dart View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/scheduled_test/test/scheduled_test/capture_stack_traces_test.dart View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M pkg/scheduled_test/test/scheduled_test/nested_task_test.dart View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M pkg/scheduled_test/test/scheduled_test/wrap_future_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/scheduled_test/test/substitute_future_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/scheduled_test/test/utils.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/scheduled_test/test/value_future_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/unittest/lib/src/core_matchers.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M pkg/unittest/lib/src/future_matchers.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M pkg/unittest/lib/src/test_case.dart View 1 3 chunks +6 lines, -5 lines 0 comments Download
M pkg/webdriver/lib/webdriver.dart View 3 chunks +10 lines, -9 lines 0 comments Download
M pkg/webdriver/test/webdriver_test.dart View 2 chunks +7 lines, -5 lines 0 comments Download
M runtime/bin/socket_patch.dart View 1 2 3 4 5 chunks +6 lines, -6 lines 0 comments Download
M runtime/embedders/openglui/common/gl.dart View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/lib/isolate_patch.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/tests/vm/dart/isolate_mirror_local_test.dart View 1 2 3 3 chunks +11 lines, -11 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/samples/leap/leap_server.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M sdk/lib/_internal/dartdoc/bin/dartdoc.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/dartdoc/lib/dartdoc.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M sdk/lib/async/async_error.dart View 1 2 1 chunk +8 lines, -64 lines 0 comments Download
M sdk/lib/async/future.dart View 9 chunks +11 lines, -22 lines 0 comments Download
M sdk/lib/async/future_impl.dart View 22 chunks +39 lines, -57 lines 0 comments Download
M sdk/lib/async/stream.dart View 1 2 3 4 25 chunks +27 lines, -31 lines 0 comments Download
M sdk/lib/async/stream_controller.dart View 1 2 3 4 3 chunks +7 lines, -14 lines 0 comments Download
M sdk/lib/async/stream_impl.dart View 1 2 3 4 5 22 chunks +37 lines, -29 lines 0 comments Download
M sdk/lib/async/stream_pipe.dart View 1 2 3 4 16 chunks +31 lines, -38 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 3 chunks +5 lines, -7 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +5 lines, -7 lines 0 comments Download
M sdk/lib/io/data_transformer.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/io/file_impl.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/http_impl.dart View 1 2 3 4 12 chunks +14 lines, -14 lines 0 comments Download
M sdk/lib/io/http_parser.dart View 1 2 3 4 8 chunks +13 lines, -20 lines 0 comments Download
M sdk/lib/io/io_sink.dart View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/io/secure_server_socket.dart View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
sdk/lib/io/secure_socket.dart View 1 2 3 4 3 chunks +7 lines, -11 lines 0 comments Download
M sdk/lib/io/stdio.dart View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/io/string_transformer.dart View 1 chunk +1 line, -3 lines 0 comments Download
M sdk/lib/io/websocket_impl.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/isolate/isolate_stream.dart View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M tests/co19/co19-compiler.status View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 2 3 4 2 chunks +9 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/analyze_only_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/fileapi_test.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M tests/html/xhr_test.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M tests/isolate/global_error_handler_stream2_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/lib/async/event_helper.dart View 1 2 3 4 5 chunks +6 lines, -6 lines 0 comments Download
M tests/lib/async/future_delayed_error_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/lib/async/future_test.dart View 16 chunks +38 lines, -36 lines 0 comments Download
M tests/lib/async/futures_test.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M tests/lib/async/stream_controller_async_test.dart View 12 chunks +17 lines, -14 lines 0 comments Download
M tests/lib/async/stream_controller_test.dart View 1 2 3 4 7 chunks +18 lines, -18 lines 0 comments Download
M tests/lib/async/stream_event_transform_test.dart View 2 chunks +7 lines, -8 lines 0 comments Download
M tests/lib/async/stream_single_test.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/lib/async/stream_state_helper.dart View 1 2 3 4 4 chunks +6 lines, -6 lines 0 comments Download
M tests/lib/async/stream_subscription_as_future_test.dart View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/debugger/debug_lib.dart View 2 chunks +9 lines, -2 lines 0 comments Download
M tests/standalone/io/dart_std_io_pipe_test.dart View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/directory_error_test.dart View 8 chunks +16 lines, -17 lines 0 comments Download
M tests/standalone/io/directory_test.dart View 5 chunks +10 lines, -12 lines 0 comments Download
M tests/standalone/io/echo_server_stream_test.dart View 1 2 3 2 chunks +8 lines, -2 lines 0 comments Download
M tests/standalone/io/file_error_test.dart View 1 2 3 4 14 chunks +28 lines, -28 lines 0 comments Download
M tests/standalone/io/file_invalid_arguments_test.dart View 1 2 3 4 5 chunks +14 lines, -14 lines 0 comments Download
M tests/standalone/io/file_test.dart View 1 2 3 4 2 chunks +7 lines, -3 lines 0 comments Download
M tests/standalone/io/http_10_test.dart View 4 chunks +25 lines, -5 lines 0 comments Download
M tests/standalone/io/http_content_length_test.dart View 7 chunks +31 lines, -10 lines 0 comments Download
M tests/standalone/io/http_redirect_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/io/http_server_early_client_close_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/standalone/io/http_server_early_server_close_test.dart View 1 chunk +4 lines, -1 line 0 comments Download
M tests/standalone/io/http_server_response_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_server_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M tests/standalone/io/https_server_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M tests/standalone/io/process_start_exception_test.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M tests/standalone/io/raw_secure_server_socket_test.dart View 1 2 3 3 chunks +10 lines, -12 lines 0 comments Download
M tests/standalone/io/raw_secure_socket_pause_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M tests/standalone/io/raw_secure_socket_test.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M tests/standalone/io/raw_socket_test.dart View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M tests/standalone/io/secure_no_builtin_roots_database_test.dart View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/io/secure_no_builtin_roots_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/io/secure_server_socket_test.dart View 1 2 3 3 chunks +10 lines, -12 lines 0 comments Download
M tests/standalone/io/secure_socket_test.dart View 1 chunk +6 lines, -1 line 0 comments Download
M tests/standalone/io/socket_exception_test.dart View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/socket_many_connections_test.dart View 1 chunk +4 lines, -1 line 0 comments Download
M tests/standalone/io/socket_test.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M tests/standalone/io/string_transformer_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/testing_server.dart View 1 chunk +4 lines, -1 line 0 comments Download
M tests/standalone/io/web_socket_protocol_processor_test.dart View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M tests/utils/dummy_compiler_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/utils/recursive_import_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/ddbg.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/src/EventStreamProvider.dart View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M tools/dom/src/ModelTreeObserver.dart View 1 chunk +1 line, -3 lines 0 comments Download
M tools/testing/dart/drt_updater.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tools/testing/dart/http_server.dart View 6 chunks +7 lines, -8 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 4 chunks +4 lines, -0 lines 0 comments Download
tools/testing/dart/test_suite.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/utils.dart View 2 chunks +14 lines, -3 lines 0 comments Download
M tools/version.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M utils/apidoc/apidoc.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M utils/pub/command_lish.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M utils/pub/command_uploader.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M utils/pub/error_group.dart View 1 2 3 4 6 chunks +9 lines, -9 lines 0 comments Download
M utils/pub/hosted_source.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M utils/pub/http.dart View 1 chunk +10 lines, -10 lines 0 comments Download
M utils/pub/io.dart View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M utils/pub/log.dart View 1 chunk +10 lines, -1 line 0 comments Download
M utils/pub/oauth2.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M utils/pub/pub.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M utils/pub/safe_http_server.dart View 1 2 3 4 2 chunks +3 lines, -4 lines 0 comments Download
M utils/pub/utils.dart View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M utils/tests/pub/error_group_test.dart View 17 chunks +20 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
floitsch
Still some tests failing, and co19 needs status file updates, but you can already start ...
7 years, 8 months ago (2013-04-15 12:31:43 UTC) #1
floitsch
7 years, 8 months ago (2013-04-15 16:11:35 UTC) #2
floitsch
Note: we are working on a follow-up CL that will move the getAttachedStackTrace method.
7 years, 8 months ago (2013-04-15 16:12:02 UTC) #3
Anders Johnsen
LGTM https://codereview.chromium.org/14251006/diff/124/pkg/scheduled_test/lib/src/value_future.dart File pkg/scheduled_test/lib/src/value_future.dart (right): https://codereview.chromium.org/14251006/diff/124/pkg/scheduled_test/lib/src/value_future.dart#newcode33 pkg/scheduled_test/lib/src/value_future.dart:33: Future catchError(onError(Object asyncError), {bool test(error)}) => error. https://codereview.chromium.org/14251006/diff/124/pkg/scheduled_test/lib/src/value_future.dart#newcode35 ...
7 years, 8 months ago (2013-04-15 16:34:17 UTC) #4
floitsch
https://codereview.chromium.org/14251006/diff/124/pkg/scheduled_test/lib/src/value_future.dart File pkg/scheduled_test/lib/src/value_future.dart (right): https://codereview.chromium.org/14251006/diff/124/pkg/scheduled_test/lib/src/value_future.dart#newcode33 pkg/scheduled_test/lib/src/value_future.dart:33: Future catchError(onError(Object asyncError), {bool test(error)}) => On 2013/04/15 16:34:17, ...
7 years, 8 months ago (2013-04-15 18:54:10 UTC) #5
floitsch
7 years, 8 months ago (2013-04-15 19:00:19 UTC) #6
Message was sent while issue was closed. 
Committed patchset #6 manually as r21498 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698