Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Unified Diff: utils/pub/io.dart

Issue 14251006: Remove AsyncError with Expando. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/pub/http.dart ('k') | utils/pub/log.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/io.dart
diff --git a/utils/pub/io.dart b/utils/pub/io.dart
index b6968ba0a5dc5fdfd5e14a387f7491bd5ed76692..697e02bd8c648e3438ee021203cee51274c5b855 100644
--- a/utils/pub/io.dart
+++ b/utils/pub/io.dart
@@ -299,7 +299,7 @@ EventSink<List<int>> _wrapStdio(IOSink sink, String name) {
pair.last.catchError((e) {
// This log may or may not work, depending on how the stream failed. Not
// much we can do about that.
- log.error("Error writing to $name: $e");
+ log.error("Error writing to $name", e);
exit(exit_codes.IO);
});
return pair.first;
@@ -670,7 +670,7 @@ ByteStream createTarGz(List contents, {baseDir}) {
}).catchError((e) {
// We don't have to worry about double-signaling here, since the store()
// above will only be reached if startProcess succeeds.
- controller.addError(e.error, e.stackTrace);
+ controller.addError(e);
controller.close();
});
return new ByteStream(controller.stream);
@@ -707,7 +707,7 @@ ByteStream createTarGz(List contents, {baseDir}) {
}).catchError((e) {
// We don't have to worry about double-signaling here, since the store()
// above will only be reached if everything succeeds.
- controller.addError(e.error, e.stackTrace);
+ controller.addError(e);
controller.close();
});
return new ByteStream(controller.stream);
« no previous file with comments | « utils/pub/http.dart ('k') | utils/pub/log.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698