Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1412)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 14251006: Remove AsyncError with Expando. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/http_server.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 5dd8e19e161a56e3d8b7a4e5d6cce466045f097f..231cdb5b88bc652caa88d7b68ce033c35f77a050 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -984,6 +984,7 @@ class RunningProcess {
timeoutTimer = new Timer(new Duration(seconds: testCase.timeout),
timeoutHandler);
}).catchError((e) {
+ // TODO(floitsch): should we try to report the stacktrace?
print("Process error:");
print(" Command: $command");
print(" Error: $e");
@@ -1243,6 +1244,7 @@ class BatchRunnerProcess {
});
callback();
}).catchError((e) {
+ // TODO(floitsch): should we try to report the stacktrace?
print("Process error:");
print(" Command: $_executable ${_batchArguments.join(' ')}");
print(" Error: $e");
@@ -1414,6 +1416,7 @@ class ProcessQueue {
}
});
}).catchError((e) {
+ // TODO(floitsch): should we try to report the stacktrace?
print("Error starting process:");
print(" Command: $cmd ${arg.join(' ')}");
print(" Error: $e");
@@ -1479,6 +1482,7 @@ class ProcessQueue {
stdoutStringStream.listen(seleniumServerHandler);
stderrStringStream.listen(seleniumServerHandler);
}).catchError((e) {
+ // TODO(floitsch): should we try to report the stacktrace?
print("Process error:");
print(" Command: java -jar $file");
print(" Error: $e");
« no previous file with comments | « tools/testing/dart/http_server.dart ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698