Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1208)

Unified Diff: runtime/bin/socket_patch.dart

Issue 14251006: Remove AsyncError with Expando. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/webdriver/test/webdriver_test.dart ('k') | runtime/embedders/openglui/common/gl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/socket_patch.dart
diff --git a/runtime/bin/socket_patch.dart b/runtime/bin/socket_patch.dart
index 779469a709a1dc10f255dab7eb87ef13e9fbf62c..6f8e72d2471d0173b8677e89a8898e96e75a3666 100644
--- a/runtime/bin/socket_patch.dart
+++ b/runtime/bin/socket_patch.dart
@@ -443,14 +443,14 @@ class _RawServerSocket extends Stream<RawSocket>
if (socket != null) _controller.add(new _RawSocket(socket));
},
error: (e) {
- _controller.addError(new AsyncError(e));
+ _controller.addError(e);
_controller.close();
}
);
}
StreamSubscription<RawSocket> listen(void onData(RawSocket event),
- {void onError(AsyncError error),
+ {void onError(Object error),
void onDone(),
bool cancelOnError}) {
return _controller.stream.listen(
@@ -518,7 +518,7 @@ class _RawSocket extends Stream<RawSocketEvent>
},
closed: () => _controller.add(RawSocketEvent.READ_CLOSED),
error: (e) {
- _controller.addError(new AsyncError(e));
+ _controller.addError(e);
close();
}
);
@@ -539,7 +539,7 @@ class _RawSocket extends Stream<RawSocketEvent>
}
StreamSubscription<RawSocketEvent> listen(void onData(RawSocketEvent event),
- {void onError(AsyncError error),
+ {void onError(Object error),
void onDone(),
bool cancelOnError}) {
return _controller.stream.listen(
@@ -633,7 +633,7 @@ class _ServerSocket extends Stream<Socket>
_ServerSocket(this._socket);
StreamSubscription<Socket> listen(void onData(Socket event),
- {void onError(AsyncError error),
+ {void onError(error),
void onDone(),
bool cancelOnError}) {
return _socket.map((rawSocket) => new _Socket(rawSocket)).listen(
@@ -790,7 +790,7 @@ class _Socket extends Stream<List<int>> implements Socket {
_NativeSocket get _nativeSocket => _raw._socket;
StreamSubscription<List<int>> listen(void onData(List<int> event),
- {void onError(AsyncError error),
+ {void onError(error),
void onDone(),
bool cancelOnError}) {
return _controller.stream.listen(
« no previous file with comments | « pkg/webdriver/test/webdriver_test.dart ('k') | runtime/embedders/openglui/common/gl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698