Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: tools/testing/dart/http_server.dart

Issue 14251006: Remove AsyncError with Expando. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/drt_updater.dart ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/http_server.dart
diff --git a/tools/testing/dart/http_server.dart b/tools/testing/dart/http_server.dart
index feffa4c5d988fe58168a55169027aa049046aa99..cc1e41475b4f41427d4cdc21ec3d94be7d336102 100644
--- a/tools/testing/dart/http_server.dart
+++ b/tools/testing/dart/http_server.dart
@@ -142,7 +142,7 @@ class TestingServers {
}
},
onError: (e) {
- DebugLogger.error('HttpServer: an error occured: $e');
+ DebugLogger.error('HttpServer: an error occured', e);
});
_serverList.add(httpServer);
});
@@ -186,7 +186,7 @@ class TestingServers {
response.headers.set("Access-Control-Allow-Origin", "*");
request.pipe(response).catchError((e) {
DebugLogger.warning(
- 'HttpServer: error while closing the response stream: $e');
+ 'HttpServer: error while closing the response stream', e);
});
}
@@ -196,12 +196,11 @@ class TestingServers {
websocket.send(data);
websocket.close();
}, onError: (e) {
- DebugLogger.warning(
- 'HttpServer: error while echoing to WebSocket: $e');
+ DebugLogger.warning('HttpServer: error while echoing to WebSocket', e);
});
}).catchError((e) {
DebugLogger.warning(
- 'HttpServer: error while transforming to WebSocket: $e');
+ 'HttpServer: error while transforming to WebSocket', e);
});
}
@@ -286,7 +285,7 @@ class TestingServers {
response.close();
response.done.catchError((e) {
DebugLogger.warning(
- 'HttpServer: error while closing the response stream: $e');
+ 'HttpServer: error while closing the response stream', e);
});
}
@@ -336,7 +335,7 @@ class TestingServers {
}
file.openRead().pipe(response).catchError((e) {
DebugLogger.warning(
- 'HttpServer: error while closing the response stream: $e');
+ 'HttpServer: error while closing the response stream', e);
});
}
@@ -352,7 +351,7 @@ class TestingServers {
response.close();
response.done.catchError((e) {
DebugLogger.warning(
- 'HttpServer: error while closing the response stream: $e');
+ 'HttpServer: error while closing the response stream', e);
});
}
}
« no previous file with comments | « tools/testing/dart/drt_updater.dart ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698