Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: tests/standalone/io/secure_server_socket_test.dart

Issue 14251006: Remove AsyncError with Expando. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/io/secure_no_builtin_roots_test.dart ('k') | tests/standalone/io/secure_socket_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/secure_server_socket_test.dart
diff --git a/tests/standalone/io/secure_server_socket_test.dart b/tests/standalone/io/secure_server_socket_test.dart
index 048f9870e30214e9c9c22919f45a7274a5d7e073..dbe0355b4e2d31cf58b50c7a32f828ece65ffd9b 100644
--- a/tests/standalone/io/secure_server_socket_test.dart
+++ b/tests/standalone/io/secure_server_socket_test.dart
@@ -42,16 +42,16 @@ void testInvalidBind() {
// Bind to a unknown DNS name.
SecureServerSocket.bind("ko.faar.__hest__", 0, 5, CERTIFICATE).then((_) {
Expect.fail("Failure expected");
- }).catchError((e) {
- Expect.isTrue(e.error is SocketIOException);
+ }).catchError((error) {
+ Expect.isTrue(error is SocketIOException);
port.toSendPort().send(1);
});
// Bind to an unavaliable IP-address.
SecureServerSocket.bind("8.8.8.8", 0, 5, CERTIFICATE).then((_) {
Expect.fail("Failure expected");
- }).catchError((e) {
- Expect.isTrue(e.error is SocketIOException);
+ }).catchError((error) {
+ Expect.isTrue(error is SocketIOException);
port.toSendPort().send(1);
});
@@ -69,9 +69,9 @@ void testInvalidBind() {
s.close();
t.close();
port.toSendPort().send(1);
- }).catchError((e) {
+ }).catchError((error) {
Expect.notEquals('windows', Platform.operatingSystem);
- Expect.isTrue(e.error is SocketIOException);
+ Expect.isTrue(error is SocketIOException);
s.close();
port.toSendPort().send(1);
});
@@ -100,16 +100,14 @@ void testSimpleConnectFail(String certificate) {
.then((clientEnd) {
Expect.fail("No client connection expected.");
})
- .catchError((e) {
- Expect.isTrue(e is AsyncError);
- Expect.isTrue(e.error is SocketIOException);
+ .catchError((error) {
+ Expect.isTrue(error is SocketIOException);
});
server.listen((serverEnd) {
Expect.fail("No server connection expected.");
},
- onError: (e) {
- Expect.isTrue(e is AsyncError);
- Expect.isTrue(e.error is SocketIOException);
+ onError: (error) {
+ Expect.isTrue(error is SocketIOException);
clientEndFuture.then((_) => port.close());
});
});
« no previous file with comments | « tests/standalone/io/secure_no_builtin_roots_test.dart ('k') | tests/standalone/io/secure_socket_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698