Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Unified Diff: sdk/lib/_internal/dartdoc/lib/dartdoc.dart

Issue 14251006: Remove AsyncError with Expando. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/dartdoc/bin/dartdoc.dart ('k') | sdk/lib/async/async_error.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/dartdoc/lib/dartdoc.dart
diff --git a/sdk/lib/_internal/dartdoc/lib/dartdoc.dart b/sdk/lib/_internal/dartdoc/lib/dartdoc.dart
index 38d17063037edc0e77d4090da0fa1e9d01bfc293..9057b6e8a45660a1e3e1fda3bbe00629f3754d91 100644
--- a/sdk/lib/_internal/dartdoc/lib/dartdoc.dart
+++ b/sdk/lib/_internal/dartdoc/lib/dartdoc.dart
@@ -126,7 +126,7 @@ Future copyDirectory(Path from, Path to) {
}
},
onDone: () => completer.complete(),
- onError: (e) => completer.completeError(e.error, e.stackTrace));
+ onError: (e) => completer.completeError(e));
return completer.future;
}
@@ -163,8 +163,10 @@ void _compileScript() {
});
}).then((_) {
replyTo.send(['success']);
- }).catchError((e) {
- replyTo.send(['error', e.error.toString(), e.stackTrace.toString()]);
+ }).catchError((error) {
+ var trace = getAttachedStackTrace(error);
+ var traceString = trace == null ? "" : trace.toString();
+ replyTo.send(['error', error.toString(), traceString]);
});
});
}
« no previous file with comments | « sdk/lib/_internal/dartdoc/bin/dartdoc.dart ('k') | sdk/lib/async/async_error.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698