Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: utils/pub/safe_http_server.dart

Issue 14251006: Remove AsyncError with Expando. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/pub/pub.dart ('k') | utils/pub/utils.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/safe_http_server.dart
diff --git a/utils/pub/safe_http_server.dart b/utils/pub/safe_http_server.dart
index 9c793a0b02f8f8349df9e149684b714ddc61cbfe..79417bcc770d80b9bb1893753d5388ffb4357d86 100644
--- a/utils/pub/safe_http_server.dart
+++ b/utils/pub/safe_http_server.dart
@@ -42,13 +42,12 @@ class SafeHttpServer extends StreamView<HttpRequest> implements HttpServer {
HttpConnectionsInfo connectionsInfo() => _inner.connectionsInfo();
StreamSubscription<HttpRequest> listen(void onData(HttpRequest value),
- {void onError(AsyncError error), void onDone(),
+ {void onError(error), void onDone(),
bool cancelOnError: false}) {
var subscription;
subscription = super.listen((request) {
onData(new _HttpRequestWrapper(request));
- }, onError: (e) {
- var error = e.error;
+ }, onError: (error) {
// Ignore socket error 104, which is caused by a request being cancelled
// before it writes any headers. There's no reason to care about such
// requests.
@@ -58,7 +57,7 @@ class SafeHttpServer extends StreamView<HttpRequest> implements HttpServer {
// Manually handle cancelOnError so the above (ignored) errors don't
// cause unsubscription.
if (cancelOnError) subscription.cancel();
- if (onError != null) onError(e);
+ if (onError != null) onError(error);
}, onDone: onDone);
return subscription;
}
« no previous file with comments | « utils/pub/pub.dart ('k') | utils/pub/utils.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698