Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: pkg/scheduled_test/lib/src/scheduled_future_matchers.dart

Issue 14251006: Remove AsyncError with Expando. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/scheduled_test/lib/src/scheduled_future_matchers.dart
diff --git a/pkg/scheduled_test/lib/src/scheduled_future_matchers.dart b/pkg/scheduled_test/lib/src/scheduled_future_matchers.dart
index 83609f552517ec5ccde001d1788dd90aa9967c64..599613dee8bd4cffd484de108989df1c4d29b966 100644
--- a/pkg/scheduled_test/lib/src/scheduled_future_matchers.dart
+++ b/pkg/scheduled_test/lib/src/scheduled_future_matchers.dart
@@ -66,11 +66,10 @@ class _ScheduledCompletes extends BaseMatcher {
currentSchedule.wrapFuture(item.then((value) {
if (_matcher == null) return;
- try {
- expect(value, _matcher);
- } catch (e, stackTrace) {
- throw new AsyncError(e, outerTrace);
- }
+ // TODO(floitsch): we cannot switch traces anymore.
+ // If expect throws we might want to be able to switch to the outer trace
+ // instead.
+ expect(value, _matcher);
}), description);
return true;
« no previous file with comments | « pkg/scheduled_test/lib/src/schedule_error.dart ('k') | pkg/scheduled_test/lib/src/scheduled_server/safe_http_server.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698