Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: sdk/lib/async/stream_controller.dart

Issue 14251006: Remove AsyncError with Expando. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/async/stream.dart ('k') | sdk/lib/async/stream_impl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/async/stream_controller.dart
diff --git a/sdk/lib/async/stream_controller.dart b/sdk/lib/async/stream_controller.dart
index 7378bef79897de76f5d0c9dc1f3004dd15f3c91e..a7129bb213256ecd656dfad13c2da452f135d862 100644
--- a/sdk/lib/async/stream_controller.dart
+++ b/sdk/lib/async/stream_controller.dart
@@ -119,23 +119,16 @@ class StreamController<T> extends EventSink<T> {
/**
* Send or enqueue an error event.
*
- * If [error] is not an [AsyncError], [error] and an optional [stackTrace]
- * is combined into an [AsyncError] and sent this stream's listeners.
- *
- * Otherwise, if [error] is an [AsyncError], it is used directly as the
- * error object reported to listeners, and the [stackTrace] is ignored.
- *
* If a subscription has requested to be unsubscribed on errors,
* it will be unsubscribed after receiving this event.
*/
void addError(Object error, [Object stackTrace]) {
- AsyncError asyncError;
- if (error is AsyncError) {
- asyncError = error;
- } else {
- asyncError = new AsyncError(error, stackTrace);
+ if (stackTrace != null) {
+ // Force stack trace overwrite. Even if the error already contained
+ // a stack trace.
+ _attachStackTrace(error, stackTrace);
}
- stream._addError(asyncError);
+ stream._addError(error);
}
/**
@@ -161,7 +154,7 @@ class _MultiControllerStream<T> extends _MultiStreamImpl<T> {
try {
notificationHandler();
} catch (e, s) {
- new AsyncError(e, s).throwDelayed();
+ _throwDelayed(e, s);
}
}
@@ -191,7 +184,7 @@ class _SingleControllerStream<T> extends _SingleStreamImpl<T> {
try {
notificationHandler();
} catch (e, s) {
- new AsyncError(e, s).throwDelayed();
+ _throwDelayed(e, s);
}
}
« no previous file with comments | « sdk/lib/async/stream.dart ('k') | sdk/lib/async/stream_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698