Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: utils/pub/utils.dart

Issue 14251006: Remove AsyncError with Expando. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/pub/safe_http_server.dart ('k') | utils/tests/pub/error_group_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/utils.dart
diff --git a/utils/pub/utils.dart b/utils/pub/utils.dart
index 85411740ea88091e772444df540cb13fb09644a7..818fe34acba5d05b0553761c144be2d8ad8b3e23 100644
--- a/utils/pub/utils.dart
+++ b/utils/pub/utils.dart
@@ -59,7 +59,7 @@ class FutureGroup<T> {
if (completed) return;
completed = true;
- _completer.completeError(e.error, e.stackTrace);
+ _completer.completeError(e);
}));
return task;
@@ -156,7 +156,7 @@ Future sleep(int milliseconds) {
/// to [completer].
void chainToCompleter(Future future, Completer completer) {
future.then((value) => completer.complete(value),
- onError: (e) => completer.completeError(e.error, e.stackTrace));
+ onError: (e) => completer.completeError(e));
}
// TODO(nweiz): remove this when issue 7964 is fixed.
@@ -169,7 +169,7 @@ Future streamFirst(Stream stream) {
subscription.cancel();
completer.complete(value);
}, onError: (e) {
- completer.completeError(e.error, e.stackTrace);
+ completer.completeError(e);
}, onDone: () {
completer.completeError(new StateError("No elements"));
}, cancelOnError: true);
« no previous file with comments | « utils/pub/safe_http_server.dart ('k') | utils/tests/pub/error_group_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698