dart2js: Fix hints in code base.

dart2js: Fix hints in code base.

BUG=
R=karlklose@google.com

Committed: https://github.com/dart-lang/sdk/commit/dfcadddb11a2b52f88b2eab863e74d664651fb19

[herhut, 2015-06-11 10:48:47]

herhut@google.com changed reviewers:
+ karlklose@google.com

[herhut, 2015-06-11 10:49:16]

PTAL, This removes unused imports, unused locals and fixes some used types from
the element model.

[karlklose, 2015-06-11 10:56:15]

karlklose@google.com changed reviewers:
+ johnniwinther@google.com

[karlklose, 2015-06-11 10:56:16]

Except removing helper imports LGTM.

Maybe we should put them into dart2jslib, so that they can easily be found by
editors?

https://codereview.chromium.org/1173403002/diff/20001/pkg/compiler/lib/src/so...
File pkg/compiler/lib/src/source_file_provider.dart (right):

https://codereview.chromium.org/1173403002/diff/20001/pkg/compiler/lib/src/so...
pkg/compiler/lib/src/source_file_provider.dart:179: if (kind !=
api.Diagnostic.INFO) {
Indentation.

https://codereview.chromium.org/1173403002/diff/20001/pkg/compiler/lib/src/us...
File pkg/compiler/lib/src/use_unused_api.dart (right):

https://codereview.chromium.org/1173403002/diff/20001/pkg/compiler/lib/src/us...
pkg/compiler/lib/src/use_unused_api.dart:85: 
Revert.

[karlklose, 2015-06-11 11:09:42]

On second thought, the imports are not minimal currently and  are not present in
every file. We should remove them for now and find a central place for one
import.

[herhut, 2015-06-11 11:11:23]

Committed patchset #2 (id:20001) manually as
dfcadddb11a2b52f88b2eab863e74d664651fb19 (presubmit successful).

[herhut, 2015-06-11 12:48:56]

I addressed the comments in 

https://codereview.chromium.org//1173423002

as I had already committed.

https://codereview.chromium.org/1173403002/diff/20001/pkg/compiler/lib/src/so...
File pkg/compiler/lib/src/source_file_provider.dart (right):

https://codereview.chromium.org/1173403002/diff/20001/pkg/compiler/lib/src/so...
pkg/compiler/lib/src/source_file_provider.dart:179: if (kind !=
api.Diagnostic.INFO) {
On 2015/06/11 10:56:16, karlklose wrote:
> Indentation.

Will do in follow-up CL...

https://codereview.chromium.org/1173403002/diff/20001/pkg/compiler/lib/src/us...
File pkg/compiler/lib/src/use_unused_api.dart (right):

https://codereview.chromium.org/1173403002/diff/20001/pkg/compiler/lib/src/us...
pkg/compiler/lib/src/use_unused_api.dart:85: 
On 2015/06/11 10:56:16, karlklose wrote:
> Revert.

Done.