Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: pkg/compiler/lib/src/elements/common.dart

Issue 1173403002: dart2js: Fix hints in code base. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Updated to latest revision Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /// Mixins that implement convenience methods on [Element] subclasses. 5 /// Mixins that implement convenience methods on [Element] subclasses.
6 6
7 library elements.common; 7 library elements.common;
8 8
9 import '../dart2jslib.dart' show Compiler, isPrivateName; 9 import '../dart2jslib.dart' show Compiler, isPrivateName;
10 import '../dart_types.dart' show DartType, InterfaceType, FunctionType; 10 import '../dart_types.dart' show DartType, InterfaceType, FunctionType;
11 import '../universe/universe.dart' show Selector;
12 import '../util/util.dart' show Link; 11 import '../util/util.dart' show Link;
13 12
14 import 'elements.dart'; 13 import 'elements.dart';
15 14
16 abstract class ElementCommon implements Element { 15 abstract class ElementCommon implements Element {
17 @override 16 @override
18 bool get isLibrary => kind == ElementKind.LIBRARY; 17 bool get isLibrary => kind == ElementKind.LIBRARY;
19 18
20 @override 19 @override
21 bool get isCompilationUnit => kind == ElementKind.COMPILATION_UNIT; 20 bool get isCompilationUnit => kind == ElementKind.COMPILATION_UNIT;
(...skipping 442 matching lines...) Expand 10 before | Expand all | Expand 10 after
464 // this signature must not have more required parameters. Having more 463 // this signature must not have more required parameters. Having more
465 // optional parameters is not a problem, they simply are never provided 464 // optional parameters is not a problem, they simply are never provided
466 // by call sites of a call to a method with the other signature. 465 // by call sites of a call to a method with the other signature.
467 int otherTotalCount = signature.parameterCount; 466 int otherTotalCount = signature.parameterCount;
468 return requiredParameterCount <= otherTotalCount 467 return requiredParameterCount <= otherTotalCount
469 && parameterCount >= otherTotalCount; 468 && parameterCount >= otherTotalCount;
470 } 469 }
471 return true; 470 return true;
472 } 471 }
473 } 472 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698