pkg/compiler/lib/src/dart_backend/placeholder_collector.dart - Issue 1173403002: dart2js: Fix hints in code base.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/dart_backend/placeholder_collector.dart

Issue 1173403002: dart2js: Fix hints in code base. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Updated to latest revision Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/dart_backend/placeholder_collector.dart

diff --git a/pkg/compiler/lib/src/dart_backend/placeholder_collector.dart b/pkg/compiler/lib/src/dart_backend/placeholder_collector.dart

index e32f4a5a91e15a1955ace9ca78c633eedce3adae..12c70b367f6a61cf44dcf40994a2ae7531fa3a26 100644

--- a/pkg/compiler/lib/src/dart_backend/placeholder_collector.dart

+++ b/pkg/compiler/lib/src/dart_backend/placeholder_collector.dart

@@ -337,7 +337,6 @@ class PlaceholderCollector extends Visitor {

// collector logic in visitVariableDefinitions when resolver becomes better

// and/or catch syntax changes.

if (node.type == null) return;

- Element definitionElement = treeElements[node.definitions.nodes.head];

bool requiresVar = !node.modifiers.isFinalOrConst;

declarationTypePlaceholders.add(

new DeclarationTypePlaceholder(node.type, requiresVar));