dart2js: Fix hints in code base.

pkg/compiler/lib/src/source_file_provider.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library source_file_provider;
 
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
 import 'dart:math' as math;
@@ skipping 155 matching lines @@
 
     bool fatal = (kind.ordinal & FATAL) != 0;
     bool isInfo = (kind.ordinal & INFO) != 0;
     if (isInfo && uri == null && kind != api.Diagnostic.INFO) {
       info(message, kind);
       return;
     }
 
     message = prefixMessage(message, kind);
 
-    // [previousKind]/[lastKind] records the previous non-INFO kind we saw.
+    // [lastKind] records the previous non-INFO kind we saw.
     // This is used to suppress info about a warning when warnings are
     // suppressed, and similar for hints.
-    var previousKind = lastKind;
-    if (kind != api.Diagnostic.INFO) {
+     if (kind != api.Diagnostic.INFO) {

[karlklose, 2015/06/11 10:56:16]

Indentation.

[herhut, 2015/06/11 12:48:55]

Will do in follow-up CL...

       lastKind = kind;
     }
     var color;
     if (kind == api.Diagnostic.ERROR) {
       color = colors.red;
     } else if (kind == api.Diagnostic.WARNING) {
       if (!showWarnings) return;
       color = colors.magenta;
     } else if (kind == api.Diagnostic.HINT) {
       if (!showHints) return;
@@ skipping 56 matching lines @@
     if (outPath.endsWith('.js')) {
       outPath = outPath.substring(0, outPath.length - 3);
       return out.resolve('$outPath.$extension');
     } else {
       return out.resolve(extension);
     }
   }
 
   EventSink<String> call(String name, String extension) {
     Uri uri;
-    String sourceMapFileName;
     bool isPrimaryOutput = false;
     // TODO (johnniwinther, sigurdm): Make a better interface for
     // output-providers.
     if (extension == "deferred_map") {
       uri = out.resolve(name);
     } else if (name == '') {
       if (extension == 'js' || extension == 'dart') {
         isPrimaryOutput = true;
         uri = out;
-        sourceMapFileName =
-            sourceMapOut.path.substring(sourceMapOut.path.lastIndexOf('/') + 1);
       } else if (extension == 'precompiled.js') {
         uri = computePrecompiledUri(out);
         onInfo("File ($uri) is compatible with header"
                " \"Content-Security-Policy: script-src 'self'\"");
       } else if (extension == 'js.map' || extension == 'dart.map') {
         uri = sourceMapOut;
       } else if (extension == "info.json") {
         String outName = out.path.substring(out.path.lastIndexOf('/') + 1);
         uri = out.resolve('$outName.$extension');
       } else {
@@ skipping 46 matching lines @@
   var onAdd, onClose;
 
   EventSinkWrapper(this.onAdd, this.onClose);
 
   void add(String data) => onAdd(data);
 
   void addError(error, [StackTrace stackTrace]) => throw error;
 
   void close() => onClose();
 }