Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart

Issue 1173403002: dart2js: Fix hints in code base. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Updated to latest revision Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart
index 173f7c0ffa8a457956df059ab12b10a12d338ec9..1b1e100af716ec511c691d98b5ce18a86a2281c5 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart
@@ -150,7 +150,9 @@ class ContainerBuilder extends CodeEmitterHelper {
if (canBeReflected) {
jsAst.LiteralString reflectionName;
if (member.isConstructor) {
- String reflectionNameString = emitter.getReflectionName(member, name);
+ // TODO(herhut): This registers name as a mangled name. Do we need this
+ // given that we use a different name below?
+ emitter.getReflectionName(member, name);
reflectionName =
new jsAst.LiteralString(
'"new ${Elements.reconstructConstructorName(member)}"');

Powered by Google App Engine
This is Rietveld 408576698