Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Unified Diff: pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart

Issue 1173403002: dart2js: Fix hints in code base. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Updated to latest revision Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart
diff --git a/pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart b/pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart
index 7a705ddea7d0bbab16933d5344bae2606b1cbbd9..cf2dd76ad8e1762bd66567224352433c45fc8970 100644
--- a/pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart
+++ b/pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart
@@ -448,7 +448,7 @@ class SimpleTypeInferrerVisitor<T>
SideEffects sideEffects = new SideEffects.empty();
final Element outermostElement;
final InferrerEngine<T, TypeSystem<T>> inferrer;
- final Setlet<Element> capturedVariables = new Setlet<Element>();
+ final Setlet<Entity> capturedVariables = new Setlet<Entity>();
SimpleTypeInferrerVisitor.internal(analyzedElement,
this.outermostElement,
@@ -595,7 +595,7 @@ class SimpleTypeInferrerVisitor<T>
}
returnType = types.nonNullExact(cls);
} else {
- signature.forEachParameter((element) {
+ signature.forEachParameter((LocalParameterElement element) {
locals.update(element, inferrer.typeOfElement(element), node);
});
visit(node.body);
@@ -807,13 +807,12 @@ class SimpleTypeInferrerVisitor<T>
}
T rhsType;
- T indexType;
if (isIncrementOrDecrement) {
rhsType = types.uint31Type;
- if (node.isIndex) indexType = visit(node.arguments.head);
+ if (node.isIndex) visit(node.arguments.head);
} else if (node.isIndex) {
- indexType = visit(node.arguments.head);
+ visit(node.arguments.head);
rhsType = visit(node.arguments.tail.head);
} else {
rhsType = visit(node.arguments.head);

Powered by Google App Engine
This is Rietveld 408576698