dart2js: Fix hints in code base.

pkg/compiler/lib/src/scanner/class_element_parser.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of scanner;
 
 class ClassElementParser extends PartialParser {
   ClassElementParser(Listener listener) : super(listener);
 
   Token parseClassBody(Token token) => fullParseClassBody(token);
@@ skipping 39 matching lines @@
         MemberListener listener = new MemberListener(compiler, this);
         Parser parser = new ClassElementParser(listener);
         try {
           Token token = parser.parseTopLevelDeclaration(beginToken);
           assert(identical(token, endToken.next));
           cachedNode = listener.popNode();
           assert(
               invariant(
                   beginToken, listener.nodes.isEmpty,
                   message: "Non-empty listener stack: ${listener.nodes}"));
-        } on ParserError catch (e) {
+        } on ParserError {
           // TODO(ahe): Often, a ParserError is thrown while parsing the class
           // body. This means that the stack actually contains most of the
           // information synthesized below. Consider rewriting the parser so
           // endClassDeclaration is called before parsing the class body.
           Identifier name = new Identifier(findMyName(beginToken));
           NodeList typeParameters = null;
           Node supertype = null;
           NodeList interfaces = listener.makeNodeList(0, null, null, ",");
           Token extendsKeyword = null;
           NodeList body = listener.makeNodeList(0, beginToken, endToken, null);
@@ skipping 108 matching lines @@
     pushNode(null);
     String name = getMethodNameHack(method.name);
     Identifier singleIdentifierName = method.name.asIdentifier();
     if (singleIdentifierName != null && singleIdentifierName.source == name) {
       if (name != enclosingClass.name) {
         listener.reportError(singleIdentifierName,
                                  MessageKind.INVALID_UNNAMED_CONSTRUCTOR_NAME,
                                  {'name': enclosingClass.name});
       }
     }
-    ElementKind kind = ElementKind.FUNCTION;
     Element memberElement = new PartialConstructorElement(
         name, beginToken, endToken,
         ElementKind.FUNCTION,
         method.modifiers,
         enclosingClass);
     addMember(memberElement);
   }
 
   void endFields(int count, Token beginToken, Token endToken) {
     bool hasParseError = memberErrors.head;
@@ skipping 36 matching lines @@
 
   void endMetadata(Token beginToken, Token periodBeforeName, Token endToken) {
     popNode(); // Discard arguments.
     if (periodBeforeName != null) {
       popNode(); // Discard name.
     }
     popNode(); // Discard node (Send or Identifier).
     pushMetadata(new PartialMetadataAnnotation(beginToken, endToken));
   }
 }