Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1299)

Unified Diff: pkg/compiler/lib/src/source_file_provider.dart

Issue 1173403002: dart2js: Fix hints in code base. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Updated to latest revision Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/source_file_provider.dart
diff --git a/pkg/compiler/lib/src/source_file_provider.dart b/pkg/compiler/lib/src/source_file_provider.dart
index 30a75591734d35524c7e8167cf900c23cb4b5f3a..6c02b3a6ca85c1add796e78e6e5bca89d886986b 100644
--- a/pkg/compiler/lib/src/source_file_provider.dart
+++ b/pkg/compiler/lib/src/source_file_provider.dart
@@ -173,11 +173,10 @@ class FormattingDiagnosticHandler {
message = prefixMessage(message, kind);
- // [previousKind]/[lastKind] records the previous non-INFO kind we saw.
+ // [lastKind] records the previous non-INFO kind we saw.
// This is used to suppress info about a warning when warnings are
// suppressed, and similar for hints.
- var previousKind = lastKind;
- if (kind != api.Diagnostic.INFO) {
+ if (kind != api.Diagnostic.INFO) {
karlklose 2015/06/11 10:56:16 Indentation.
herhut 2015/06/11 12:48:55 Will do in follow-up CL...
lastKind = kind;
}
var color;
@@ -254,7 +253,6 @@ class RandomAccessFileOutputProvider {
EventSink<String> call(String name, String extension) {
Uri uri;
- String sourceMapFileName;
bool isPrimaryOutput = false;
// TODO (johnniwinther, sigurdm): Make a better interface for
// output-providers.
@@ -264,8 +262,6 @@ class RandomAccessFileOutputProvider {
if (extension == 'js' || extension == 'dart') {
isPrimaryOutput = true;
uri = out;
- sourceMapFileName =
- sourceMapOut.path.substring(sourceMapOut.path.lastIndexOf('/') + 1);
} else if (extension == 'precompiled.js') {
uri = computePrecompiledUri(out);
onInfo("File ($uri) is compatible with header"

Powered by Google App Engine
This is Rietveld 408576698