Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 1173403002: dart2js: Fix hints in code base. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Updated to latest revision Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/builder.dart
diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart
index 7ff185c4dfe61562264d6c64f213bddb3778b8dd..0ef26591b908ce4d5ecb0c34336f8993d993030a 100644
--- a/pkg/compiler/lib/src/ssa/builder.dart
+++ b/pkg/compiler/lib/src/ssa/builder.dart
@@ -2261,7 +2261,6 @@ class SsaBuilder extends NewResolvedVisitor {
}
bodyCallInputs.add(newObject);
ResolvedAst resolvedAst = constructor.resolvedAst;
- TreeElements elements = resolvedAst.elements;
ast.Node node = resolvedAst.node;
ClosureClassMap parameterClosureData =
compiler.closureToClassMapper.getMappingForNestedFunction(node);
@@ -2786,7 +2785,6 @@ class SsaBuilder extends NewResolvedVisitor {
localsHandler =
continueHandlers[0].mergeMultiple(continueHandlers, updateBlock);
- HLabeledBlockInformation labelInfo;
List<LabelDefinition> labels = jumpHandler.labels();
JumpTarget target = elements.getTargetDefinition(loop);
if (!labels.isEmpty) {
@@ -2922,7 +2920,7 @@ class SsaBuilder extends NewResolvedVisitor {
assert(!isAborted());
// The result of the update instruction isn't used, and can just
// be dropped.
- HInstruction updateInstruction = pop();
+ pop();
}
}
void buildBody() {
@@ -3631,7 +3629,6 @@ class SsaBuilder extends NewResolvedVisitor {
assert(type.element.isClass);
InterfaceType interface = type;
List<HInstruction> inputs = <HInstruction>[];
- bool first = true;
List<js.Expression> templates = <js.Expression>[];
for (DartType argument in interface.typeArguments) {
// As we construct the template in stages, we have to make sure that for
@@ -6529,7 +6526,6 @@ class SsaBuilder extends NewResolvedVisitor {
if (backend.classNeedsRti(cls)) {
List<HInstruction> typeInputs = <HInstruction>[];
- List<DartType> typeVariable = cls.typeVariables;
expectedType.typeArguments.forEach((DartType argument) {
typeInputs.add(analyzeTypeArgument(argument));
});
@@ -6827,9 +6823,6 @@ class SsaBuilder extends NewResolvedVisitor {
bool isDefaultCase(ast.SwitchCase switchCase),
void buildSwitchCase(ast.SwitchCase switchCase)) {
- Map<ast.CaseMatch, ConstantValue> constants =
- new Map<ast.CaseMatch, ConstantValue>();
-
HBasicBlock expressionStart = openNewBlock();
HInstruction expression = buildExpression();
if (switchCases.isEmpty) {

Powered by Google App Engine
This is Rietveld 408576698