dart2js: Fix hints in code base.

pkg/compiler/lib/src/js_backend/backend.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of js_backend;
 
 const VERBOSE_OPTIMIZER_HINTS = false;
 
 class JavaScriptItemCompilationContext extends ItemCompilationContext {
   final Set<HInstruction> boundsChecked = new Set<HInstruction>();
@@ skipping 1046 matching lines @@
 
         mapLiteralUntypedMaker = getMember('_makeLiteral');
         mapLiteralUntypedEmptyMaker = getMember('_makeEmpty');
         enqueueInResolution(mapLiteralUntypedMaker, registry);
         enqueueInResolution(mapLiteralUntypedEmptyMaker, registry);
       }
     }
     if (cls == closureClass) {
       enqueue(enqueuer, findHelper('closureFromTearOff'), registry);
     }
-    ClassElement result = null;
     if (cls == compiler.stringClass || cls == jsStringClass) {
       addInterceptors(jsStringClass, enqueuer, registry);
     } else if (cls == compiler.listClass ||
                cls == jsArrayClass ||
                cls == jsFixedArrayClass ||
                cls == jsExtendableArrayClass ||
                cls == jsUnmodifiableArrayClass) {
       addInterceptors(jsArrayClass, enqueuer, registry);
       addInterceptors(jsMutableArrayClass, enqueuer, registry);
       addInterceptors(jsFixedArrayClass, enqueuer, registry);
@@ skipping 937 matching lines @@
       if (library.isPlatformLibrary && !library.isPatched) {
         // Apply patch, if any.
         Uri patchUri = compiler.resolvePatchUri(library.canonicalUri.path);
         if (patchUri != null) {
           return compiler.patchParser.patchLibrary(loader, patchUri, library);
         }
       }
     }).then((_) {
       Uri uri = library.canonicalUri;
 
-      VariableElement findVariable(String name) {
-        return find(library, name);
-      }
-
       FunctionElement findMethod(String name) {
         return find(library, name);
       }
 
       ClassElement findClass(String name) {
         return find(library, name);
       }
 
       if (uri == DART_INTERCEPTORS) {
         getInterceptorMethod = findMethod('getInterceptor');
         getNativeInterceptorMethod = findMethod('getNativeInterceptor');
-
-        List<ClassElement> classes = [
-          jsInterceptorClass = findClass('Interceptor'),
-          jsStringClass = findClass('JSString'),
-          jsArrayClass = findClass('JSArray'),
-          // The int class must be before the double class, because the
-          // emitter relies on this list for the order of type checks.
-          jsIntClass = findClass('JSInt'),
-          jsPositiveIntClass = findClass('JSPositiveInt'),
-          jsUInt32Class = findClass('JSUInt32'),
-          jsUInt31Class = findClass('JSUInt31'),
-          jsDoubleClass = findClass('JSDouble'),
-          jsNumberClass = findClass('JSNumber'),
-          jsNullClass = findClass('JSNull'),
-          jsBoolClass = findClass('JSBool'),
-          jsMutableArrayClass = findClass('JSMutableArray'),
-          jsFixedArrayClass = findClass('JSFixedArray'),
-          jsExtendableArrayClass = findClass('JSExtendableArray'),
-          jsUnmodifiableArrayClass = findClass('JSUnmodifiableArray'),
-          jsPlainJavaScriptObjectClass = findClass('PlainJavaScriptObject'),
-          jsUnknownJavaScriptObjectClass = findClass('UnknownJavaScriptObject'),
-        ];
-
+        jsInterceptorClass = findClass('Interceptor');
+        jsStringClass = findClass('JSString');
+        jsArrayClass = findClass('JSArray');
+        // The int class must be before the double class, because the
+        // emitter relies on this list for the order of type checks.
+        jsIntClass = findClass('JSInt');
+        jsPositiveIntClass = findClass('JSPositiveInt');
+        jsUInt32Class = findClass('JSUInt32');
+        jsUInt31Class = findClass('JSUInt31');
+        jsDoubleClass = findClass('JSDouble');
+        jsNumberClass = findClass('JSNumber');
+        jsNullClass = findClass('JSNull');
+        jsBoolClass = findClass('JSBool');
+        jsMutableArrayClass = findClass('JSMutableArray');
+        jsFixedArrayClass = findClass('JSFixedArray');
+        jsExtendableArrayClass = findClass('JSExtendableArray');
+        jsUnmodifiableArrayClass = findClass('JSUnmodifiableArray');
+        jsPlainJavaScriptObjectClass = findClass('PlainJavaScriptObject');
+        jsUnknownJavaScriptObjectClass = findClass('UnknownJavaScriptObject');
         jsIndexableClass = findClass('JSIndexable');
         jsMutableIndexableClass = findClass('JSMutableIndexable');
       } else if (uri == DART_JS_HELPER) {
         initializeHelperClasses();
         assertMethod = findHelper('assertHelper');
 
         typeLiteralClass = findClass('TypeImpl');
         constMapLiteralClass = findClass('ConstantMap');
         typeVariableClass = findClass('TypeVariable');
 
@@ skipping 910 matching lines @@
   }
 }
 
 /// Records that [constant] is used by the element behind [registry].
 class Dependency {
   final ConstantValue constant;
   final Element annotatedElement;
 
   const Dependency(this.constant, this.annotatedElement);
 }