Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Unified Diff: pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart

Issue 1173403002: dart2js: Fix hints in code base. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Updated to latest revision Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart
diff --git a/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart b/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart
index e128c14e4ee408b5353b32f7479ddb9c71861cc1..13ccd0c9589ebb0bbec3ec47679ea3249fa0f8e0 100644
--- a/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart
+++ b/pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart
@@ -5,7 +5,6 @@
library tree_ir_builder;
import '../dart2jslib.dart' as dart2js;
-import '../dart_types.dart';
import '../elements/elements.dart';
import '../cps_ir/cps_ir_nodes.dart' as cps_ir;
import '../util/util.dart' show CURRENT_ELEMENT_SPANNABLE;
@@ -385,7 +384,7 @@ class Builder implements cps_ir.Visitor<Node> {
}
Expression visitNonTailThrow(cps_ir.NonTailThrow node) {
- unexpectedNode(node);
+ return unexpectedNode(node);
}
Statement continueWithExpression(cps_ir.Reference continuation,
@@ -526,8 +525,6 @@ class Builder implements cps_ir.Visitor<Node> {
Expression visitCreateFunction(cps_ir.CreateFunction node) {
FunctionDefinition def = makeSubFunction(node.definition);
- FunctionType type = node.definition.element.type;
- bool hasReturnType = !type.returnType.treatAsDynamic;
return new FunctionExpression(def);
}

Powered by Google App Engine
This is Rietveld 408576698